diff mbox series

[2/2] app/testpmd: fix max queue number when configure Tx offloads

Message ID 1619075011-11810-3-git-send-email-humin29@huawei.com (mailing list archive)
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series bugfix for testpmd | expand

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Min Hu (Connor) April 22, 2021, 7:03 a.m. UTC
From: Chengchang Tang <tangchengchang@huawei.com>

When txq offload is configured, max rxq is used as the max queue. This
patch fixes it.

Fixes: 74453ac9ef67 ("app/testpmd: fix queue offload configuration")
Cc: stable@dpdk.org

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Li, Xiaoyun April 25, 2021, 2:08 a.m. UTC | #1
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Thursday, April 22, 2021 15:04
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH 2/2] app/testpmd: fix max queue number when configure Tx
> offloads
> 
> From: Chengchang Tang <tangchengchang@huawei.com>
> 
> When txq offload is configured, max rxq is used as the max queue. This patch
> fixes it.
> 
> Fixes: 74453ac9ef67 ("app/testpmd: fix queue offload configuration")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>  app/test-pmd/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> f0fa6e8..1cb1027 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4666,7 +4666,7 @@ cmd_config_queue_tx_offloads(struct rte_port *port)
>  	int k;
> 
>  	/* Apply queue tx offloads configuration */
> -	for (k = 0; k < port->dev_info.max_rx_queues; k++)
> +	for (k = 0; k < port->dev_info.max_tx_queues; k++)
>  		port->tx_conf[k].offloads =
>  			port->dev_conf.txmode.offloads;
>  }
> --
> 2.7.4

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Ferruh Yigit April 26, 2021, 2:21 p.m. UTC | #2
On 4/25/2021 3:08 AM, Li, Xiaoyun wrote:
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Thursday, April 22, 2021 15:04
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Subject: [PATCH 2/2] app/testpmd: fix max queue number when configure Tx
>> offloads
>>
>> From: Chengchang Tang <tangchengchang@huawei.com>
>>
>> When txq offload is configured, max rxq is used as the max queue. This patch
>> fixes it.
>>
>> Fixes: 74453ac9ef67 ("app/testpmd: fix queue offload configuration")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>>  app/test-pmd/cmdline.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>> f0fa6e8..1cb1027 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -4666,7 +4666,7 @@ cmd_config_queue_tx_offloads(struct rte_port *port)
>>  int k;
>>
>>  /* Apply queue tx offloads configuration */
>> -for (k = 0; k < port->dev_info.max_rx_queues; k++)
>> +for (k = 0; k < port->dev_info.max_tx_queues; k++)
>>  port->tx_conf[k].offloads =
>>  port->dev_conf.txmode.offloads;
>>  }
>> --
>> 2.7.4
> 
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f0fa6e8..1cb1027 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4666,7 +4666,7 @@  cmd_config_queue_tx_offloads(struct rte_port *port)
 	int k;
 
 	/* Apply queue tx offloads configuration */
-	for (k = 0; k < port->dev_info.max_rx_queues; k++)
+	for (k = 0; k < port->dev_info.max_tx_queues; k++)
 		port->tx_conf[k].offloads =
 			port->dev_conf.txmode.offloads;
 }