From patchwork Thu Apr 8 10:17:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "humin (Q)" X-Patchwork-Id: 90876 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D8F5A0579; Thu, 8 Apr 2021 12:17:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C670140FF9; Thu, 8 Apr 2021 12:17:11 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id AB0BD140FC0 for ; Thu, 8 Apr 2021 12:17:09 +0200 (CEST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FGHFD0lLPz1BG8n for ; Thu, 8 Apr 2021 18:14:56 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Thu, 8 Apr 2021 18:17:02 +0800 From: "Min Hu (Connor)" To: CC: , Date: Thu, 8 Apr 2021 18:17:23 +0800 Message-ID: <1617877043-11025-1-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH] examples/helloworld: add eal clean up to the example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Chengchang Tang According to the programming guide, the rte_eal_init should be used pairs with rte_eal_cleanup. So, we should add the use of clean up to the hello world example to encourage new users of DPDK to use it. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- examples/helloworld/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c index 8a4cee6..6e403b6 100644 --- a/examples/helloworld/main.c +++ b/examples/helloworld/main.c @@ -43,5 +43,8 @@ main(int argc, char **argv) lcore_hello(NULL); rte_eal_mp_wait_lcore(); + + /* clean up the EAL */ + rte_eal_cleanup(); return 0; }