examples/helloworld: add eal clean up to the example
Checks
Commit Message
From: Chengchang Tang <tangchengchang@huawei.com>
According to the programming guide, the rte_eal_init should be used pairs
with rte_eal_cleanup.
So, we should add the use of clean up to the hello world example to
encourage new users of DPDK to use it.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
examples/helloworld/main.c | 3 +++
1 file changed, 3 insertions(+)
Comments
On Thu, Apr 8, 2021 at 12:17 PM Min Hu (Connor) <humin29@huawei.com> wrote:
>
> From: Chengchang Tang <tangchengchang@huawei.com>
>
> According to the programming guide, the rte_eal_init should be used pairs
> with rte_eal_cleanup.
>
> So, we should add the use of clean up to the hello world example to
> encourage new users of DPDK to use it.
>
> Fixes: af75078fece3 ("first public release")
rte_eal_cleanup() was introduced with aec9c13c5257 ("eal: add function
to release internal resources") from v18.02.
Other examples probably need fixes too.
$ git grep -l rte_eal_init examples/ |xargs grep -L rte_eal_cleanup |wc
52 52 1623
在 2021/4/8 19:21, David Marchand 写道:
> On Thu, Apr 8, 2021 at 12:17 PM Min Hu (Connor) <humin29@huawei.com> wrote:
>>
>> From: Chengchang Tang <tangchengchang@huawei.com>
>>
>> According to the programming guide, the rte_eal_init should be used pairs
>> with rte_eal_cleanup.
>>
>> So, we should add the use of clean up to the hello world example to
>> encourage new users of DPDK to use it.
>>
>> Fixes: af75078fece3 ("first public release")
>
> rte_eal_cleanup() was introduced with aec9c13c5257 ("eal: add function
> to release internal resources") from v18.02.
>
> Other examples probably need fixes too.
> $ git grep -l rte_eal_init examples/ |xargs grep -L rte_eal_cleanup |wc
> 52 52 1623
>
Thanks David,
I will fix other examples in next patches.
>
在 2021/4/8 21:09, Min Hu (Connor) 写道:
>
>
> 在 2021/4/8 19:21, David Marchand 写道:
>> On Thu, Apr 8, 2021 at 12:17 PM Min Hu (Connor) <humin29@huawei.com>
>> wrote:
>>>
>>> From: Chengchang Tang <tangchengchang@huawei.com>
>>>
>>> According to the programming guide, the rte_eal_init should be used
>>> pairs
>>> with rte_eal_cleanup.
>>>
>>> So, we should add the use of clean up to the hello world example to
>>> encourage new users of DPDK to use it.
>>>
>>> Fixes: af75078fece3 ("first public release")
>>
>> rte_eal_cleanup() was introduced with aec9c13c5257 ("eal: add function
>> to release internal resources") from v18.02.
>>
>> Other examples probably need fixes too.
>> $ git grep -l rte_eal_init examples/ |xargs grep -L rte_eal_cleanup |wc
>> 52 52 1623
>>
> Thanks David,
> I will fix other examples in next patches.
>>
Hi, David and all,
I have sent one set of patches to fix it, the headline is
"[PATCH 00/45] add eal clean up to the example"
Please review it, thanks.
> .
@@ -43,5 +43,8 @@ main(int argc, char **argv)
lcore_hello(NULL);
rte_eal_mp_wait_lcore();
+
+ /* clean up the EAL */
+ rte_eal_cleanup();
return 0;
}