From patchwork Thu Apr 5 15:07:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 37315 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C5C21CC98; Thu, 5 Apr 2018 17:07:35 +0200 (CEST) Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id E5AAB1CC66 for ; Thu, 5 Apr 2018 17:07:27 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id u46so29010756wrc.11 for ; Thu, 05 Apr 2018 08:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=SgYMp8U31+EnucI5urh9KazTRkOHpXZUWAjpvFRNGlE=; b=q7UJCnmmtf2/NaOMJebz67HAVv3FuyaNsExL8gkR/H9Ezz0lvgCQEoY8sGK6GE48DO Q0QzQCIJBLHIpS7Vmb8yn9xtHgkzehwwKZFLhJ8Sk3k0HpsVebHQdQXBO+Ca4P7BkxKu 0y81ufxBEvuLElu9y7C2XiZD3B5w2Gahv4amB4nshovNP9JwyqwJZm2RluFNbAz34hEC Khqo5sah/KL+1C+zXLy7x4w3PettWJ2hDQSi7NsmogUXb9IWd/Coylmp4Lrym0kylr/7 unAZ0ezBjvrWElwUlSCp1ckChdRi7STZOtjYL8ecAdfg9JC+iuM1jp0Wrw0+xFx4nkmY c3hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=SgYMp8U31+EnucI5urh9KazTRkOHpXZUWAjpvFRNGlE=; b=d0vMJRTYurZhokQvmv7Dxv9l3NIuovpao0Xdk0AdNiGk4skeZ2KRryseRyLUdgpDAz sPd5rLgjG5S5bqkhbEKyhOnvu98ixDSwdQgUZGt6F2PNHawxHig/dyaOG0XLfboqqKR0 KoTMXEtDP+H+yU+i6GcyMqihM0+E0FRK6PlP1PWwCa439FtgXy7wJMP5dVbk/V4Ch2lL YZUt+oWyA+DCzLZbbEewAHxLuox9//BM/YERAsa4ZKqIh5mMhP+GYu0b/xU0Sr0Qyjqy 63DxtXP5z05NzJPxLxCtpQdyBhn2035Rt3yE1BYHvbzcPVdL2TBA4f71fSEiYe4slwQx kNBw== X-Gm-Message-State: AElRT7EUZcCv6IUekuvZhKjWQQ8pBoLqTs0mmc/aD3/78OZYu6cvq0Z4 3TLWlza32NpsVEQuFAxNCFRXyCfkBA== X-Google-Smtp-Source: AIpwx4+t6C2NMvq2OUsMWPCR1BdV59uaErsyHwFKqQUM/8tTY16fhp9MY3aLmuda+XU3ABdbfDlvQw== X-Received: by 10.223.179.13 with SMTP id j13mr17295784wrd.165.1522940847656; Thu, 05 Apr 2018 08:07:27 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y100sm3514166wmh.2.2018.04.05.08.07.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 08:07:26 -0700 (PDT) From: Nelio Laranjeiro To: Adrien Mazarguil , Yongseok Koh Cc: dev@dpdk.org Date: Thu, 5 Apr 2018 17:07:21 +0200 Message-Id: <16178399af084c551f26f429abf81fda1438ddf3.1522940682.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v4 3/3] net/mlx5: add a parameter for Netlink support in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All Netlink request the PMD will do can also be done by a iproute2 command line interface, enabling VF behavior configuration without having to modify the application nor reaching PMD limits (e.g. MAC address number limit). Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/nics/mlx5.rst | 9 +++++++++ drivers/net/mlx5/mlx5.c | 9 ++++++++- drivers/net/mlx5/mlx5.h | 1 + 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index c812f0b4f..b1bab2ce2 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -344,6 +344,15 @@ Run-time configuration Enabled by default. +- ``vf_nl_en`` parameter [int] + + A nonzero value enables Netlink requests from the VF to add/remove MAC + addresses or/and enable/disable promiscuous/all multicast on the Netdevice. + Otherwise the relevant configuration must be run with Linux iproute2 tools. + This is a prerequisite to receive this kind of traffic. + + Enabled by default, valid only on VF devices ignored otherwise. + Prerequisites ------------- diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index e52c60fb3..cfab55897 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -69,6 +69,9 @@ /* Device parameter to enable hardware Rx vector. */ #define MLX5_RX_VEC_EN "rx_vec_en" +/* Activate Netlink support in VF mode. */ +#define MLX5_VF_NL_EN "vf_nl_en" + #ifndef HAVE_IBV_MLX5_MOD_MPW #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2) #define MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW (1 << 3) @@ -412,6 +415,8 @@ mlx5_args_check(const char *key, const char *val, void *opaque) config->tx_vec_en = !!tmp; } else if (strcmp(MLX5_RX_VEC_EN, key) == 0) { config->rx_vec_en = !!tmp; + } else if (strcmp(MLX5_VF_NL_EN, key) == 0) { + config->vf_nl_en = !!tmp; } else { DRV_LOG(WARNING, "%s: unknown parameter", key); rte_errno = EINVAL; @@ -443,6 +448,7 @@ mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs) MLX5_TXQ_MAX_INLINE_LEN, MLX5_TX_VEC_EN, MLX5_RX_VEC_EN, + MLX5_VF_NL_EN, NULL, }; struct rte_kvargs *kvlist; @@ -747,6 +753,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, .txq_inline = MLX5_ARG_UNSET, .txqs_inline = MLX5_ARG_UNSET, .inline_max_packet_sz = MLX5_ARG_UNSET, + .vf_nl_en = 1, }; len = snprintf(name, sizeof(name), PCI_PRI_FMT, @@ -963,7 +970,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, claim_zero(mlx5_mac_addr_add(eth_dev, &mac, 0, 0)); priv->nl_socket = -1; priv->nl_sn = 0; - if (vf) { + if (vf && config.vf_nl_en) { priv->nl_socket = mlx5_nl_init(RTMGRP_LINK); if (priv->nl_socket < 0) priv->nl_socket = -1; diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 50cc09946..63b24e6bb 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -88,6 +88,7 @@ struct mlx5_dev_config { unsigned int tx_vec_en:1; /* Tx vector is enabled. */ unsigned int rx_vec_en:1; /* Rx vector is enabled. */ unsigned int mpw_hdr_dseg:1; /* Enable DSEGs in the title WQEBB. */ + unsigned int vf_nl_en:1; /* Enable Netlink requests in VF mode. */ unsigned int tso_max_payload_sz; /* Maximum TCP payload for TSO. */ unsigned int ind_table_max_size; /* Maximum indirection table size. */ int txq_inline; /* Maximum packet size for inlining. */