diff mbox series

examples/ptpclient: delete wrong comments

Message ID 1616830586-46672-1-git-send-email-humin29@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series examples/ptpclient: delete wrong comments |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/travis-robot success travis build: passed
ci/github-robot success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

humin (Q) March 27, 2021, 7:36 a.m. UTC 
  This patch deletes the comments which are wrong and unnecessary.

Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 examples/ptpclient/ptpclient.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

humin (Q) April 10, 2021, 9:11 a.m. UTC | #1 
Hi, Ferruh, kirill and all,
	Any comments about this patch?

在 2021/3/27 15:36, Min Hu (Connor) 写道:
> This patch deletes the comments which are wrong and unnecessary.
> 
> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>   examples/ptpclient/ptpclient.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
> index 33b297e..878d1a0 100644
> --- a/examples/ptpclient/ptpclient.c
> +++ b/examples/ptpclient/ptpclient.c
> @@ -606,10 +606,6 @@ lcore_main(void)
>   	unsigned nb_rx;
>   	struct rte_mbuf *m;
>   
> -	/*
> -	 * Check that the port is on the same NUMA node as the polling thread
> -	 * for best performance.
> -	 */
>   	printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
>   			rte_lcore_id());
>   
>
Ferruh Yigit April 12, 2021, 8:04 a.m. UTC | #2 
On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
> Hi, Ferruh, kirill and all,
>      Any comments about this patch?
> 
> 在 2021/3/27 15:36, Min Hu (Connor) 写道:
>> This patch deletes the comments which are wrong and unnecessary.
>>
>> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>>   examples/ptpclient/ptpclient.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
>> index 33b297e..878d1a0 100644
>> --- a/examples/ptpclient/ptpclient.c
>> +++ b/examples/ptpclient/ptpclient.c
>> @@ -606,10 +606,6 @@ lcore_main(void)
>>       unsigned nb_rx;
>>       struct rte_mbuf *m;
>> -    /*
>> -     * Check that the port is on the same NUMA node as the polling thread
>> -     * for best performance.
>> -     */
>>       printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
>>               rte_lcore_id());
>>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

The comment seems left over from the example this example cloned from..
humin (Q) April 19, 2021, 7:42 a.m. UTC | #3 
Hi, Ferruh and all,
	If  no other comments, could your please merge it into the
branch？
	Thanks.

在 2021/4/12 16:04, Ferruh Yigit 写道:
> On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
>> Hi, Ferruh, kirill and all,
>>      Any comments about this patch?
>>
>> 在 2021/3/27 15:36, Min Hu (Connor) 写道:
>>> This patch deletes the comments which are wrong and unnecessary.
>>>
>>> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>> ---
>>>   examples/ptpclient/ptpclient.c | 4 ----
>>>   1 file changed, 4 deletions(-)
>>>
>>> diff --git a/examples/ptpclient/ptpclient.c 
>>> b/examples/ptpclient/ptpclient.c
>>> index 33b297e..878d1a0 100644
>>> --- a/examples/ptpclient/ptpclient.c
>>> +++ b/examples/ptpclient/ptpclient.c
>>> @@ -606,10 +606,6 @@ lcore_main(void)
>>>       unsigned nb_rx;
>>>       struct rte_mbuf *m;
>>> -    /*
>>> -     * Check that the port is on the same NUMA node as the polling 
>>> thread
>>> -     * for best performance.
>>> -     */
>>>       printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
>>>               rte_lcore_id());
>>>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> The comment seems left over from the example this example cloned from..
> .
Thomas Monjalon April 20, 2021, 1:02 a.m. UTC | #4 
12/04/2021 10:04, Ferruh Yigit:
> On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
> >> This patch deletes the comments which are wrong and unnecessary.
> >>
> >> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> >> ---
> >> --- a/examples/ptpclient/ptpclient.c
> >> +++ b/examples/ptpclient/ptpclient.c
> >> -    /*
> >> -     * Check that the port is on the same NUMA node as the polling thread
> >> -     * for best performance.
> >> -     */
> >>       printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
> >>               rte_lcore_id());
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> The comment seems left over from the example this example cloned from..

Applied, thanks
diff mbox series

Patch

diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
index 33b297e..878d1a0 100644
--- a/examples/ptpclient/ptpclient.c
+++ b/examples/ptpclient/ptpclient.c
@@ -606,10 +606,6 @@  lcore_main(void)
 	unsigned nb_rx;
 	struct rte_mbuf *m;
 
-	/*
-	 * Check that the port is on the same NUMA node as the polling thread
-	 * for best performance.
-	 */
 	printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
 			rte_lcore_id());