[1/2] common/mlx5: align driver name logs across pmds

Message ID 1615842355-10526-1-git-send-email-michaelba@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [1/2] common/mlx5: align driver name logs across pmds |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Michael Baum March 15, 2021, 9:05 p.m. UTC
From: Asaf Penso <asafp@nvidia.com>

Some mlx5 pmds define the log prefix as "mlx5_pmd" while others as
"pmd_mlx5".
The patch aligns all pmds to use the "mlx5_pmd" format.

Signed-off-by: Asaf Penso <asafp@nvidia.com>
---
 drivers/common/mlx5/mlx5_common.h       | 4 ----
 drivers/common/mlx5/mlx5_common_utils.h | 2 +-
 drivers/net/mlx5/mlx5_utils.h           | 4 +++-
 drivers/regex/mlx5/mlx5_regex_utils.h   | 2 +-
 4 files changed, 5 insertions(+), 7 deletions(-)
  

Comments

Slava Ovsiienko March 30, 2021, 7:35 a.m. UTC | #1
> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
> Sent: Monday, March 15, 2021 23:06
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; Asaf Penso <asafp@nvidia.com>
> Subject: [PATCH 1/2] common/mlx5: align driver name logs across pmds
> 
> From: Asaf Penso <asafp@nvidia.com>
> 
> Some mlx5 pmds define the log prefix as "mlx5_pmd" while others as
> "pmd_mlx5".
> The patch aligns all pmds to use the "mlx5_pmd" format.
> 
> Signed-off-by: Asaf Penso <asafp@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
  
Raslan Darawsheh April 1, 2021, 11:30 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
> Sent: Monday, March 15, 2021 11:06 PM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Raslan Darawsheh <rasland@nvidia.com>; Asaf Penso <asafp@nvidia.com>
> Subject: [PATCH 1/2] common/mlx5: align driver name logs across pmds
> 
> From: Asaf Penso <asafp@nvidia.com>
> 
> Some mlx5 pmds define the log prefix as "mlx5_pmd" while others as
> "pmd_mlx5".
> The patch aligns all pmds to use the "mlx5_pmd" format.
> 
> Signed-off-by: Asaf Penso <asafp@nvidia.com>
> ---

Series applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
  

Patch

diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h
index 3855582..fc1ac75 100644
--- a/drivers/common/mlx5/mlx5_common.h
+++ b/drivers/common/mlx5/mlx5_common.h
@@ -65,10 +65,6 @@ 
 			RTE_FMT_HEAD(__VA_ARGS__,), \
 		RTE_FMT_TAIL(__VA_ARGS__,)))
 
-/*
- * When debugging is enabled (MLX5_DEBUG not defined), file, line and function
- * information replace the driver name (MLX5_DRIVER_NAME) in log messages.
- */
 #ifdef RTE_LIBRTE_MLX5_DEBUG
 
 #define PMD_DRV_LOG__(level, type, name, ...) \
diff --git a/drivers/common/mlx5/mlx5_common_utils.h b/drivers/common/mlx5/mlx5_common_utils.h
index 32c3adf..6cba39c 100644
--- a/drivers/common/mlx5/mlx5_common_utils.h
+++ b/drivers/common/mlx5/mlx5_common_utils.h
@@ -10,7 +10,7 @@ 
 
 extern int mlx5_common_logtype;
 
-#define MLX5_COMMON_LOG_PREFIX "common_mlx5"
+#define MLX5_COMMON_LOG_PREFIX "mlx5_common"
 /* Generic printf()-like logging macro with automatic line feed. */
 #define DRV_LOG(level, ...) \
 	PMD_DRV_LOG_(level, mlx5_common_logtype, MLX5_COMMON_LOG_PREFIX, \
diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h
index 7a62187..5088c95 100644
--- a/drivers/net/mlx5/mlx5_utils.h
+++ b/drivers/net/mlx5/mlx5_utils.h
@@ -29,9 +29,11 @@ 
 
 extern int mlx5_logtype;
 
+#define MLX5_NET_LOG_PREFIX "mlx5_net"
+
 /* Generic printf()-like logging macro with automatic line feed. */
 #define DRV_LOG(level, ...) \
-	PMD_DRV_LOG_(level, mlx5_logtype, MLX5_DRIVER_NAME, \
+	PMD_DRV_LOG_(level, mlx5_logtype, MLX5_NET_LOG_PREFIX, \
 		__VA_ARGS__ PMD_DRV_LOG_STRIP PMD_DRV_LOG_OPAREN, \
 		PMD_DRV_LOG_CPAREN)
 
diff --git a/drivers/regex/mlx5/mlx5_regex_utils.h b/drivers/regex/mlx5/mlx5_regex_utils.h
index adca846..104e794 100644
--- a/drivers/regex/mlx5/mlx5_regex_utils.h
+++ b/drivers/regex/mlx5/mlx5_regex_utils.h
@@ -9,7 +9,7 @@ 
 
 extern int mlx5_regex_logtype;
 
-#define MLX5_REGEX_LOG_PREFIX "regex_mlx5"
+#define MLX5_REGEX_LOG_PREFIX "mlx5_regex"
 /* Generic printf()-like logging macro with automatic line feed. */
 #define DRV_LOG(level, ...) \
 	PMD_DRV_LOG_(level, mlx5_regex_logtype, MLX5_REGEX_LOG_PREFIX, \