diff mbox series

examples/pipeline: fix strtoul base

Message ID 1614957330-9469-1-git-send-email-churchill.khangar@intel.com (mailing list archive)
State Superseded
Delegated to: Thomas Monjalon
Headers show
Series examples/pipeline: fix strtoul base | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/travis-robot success travis build: passed
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Churchill Khangar March 5, 2021, 3:15 p.m. UTC
This patch addresses the issue with strtoul base

Fixes: 5074e1d55107 ("examples/pipeline: add configuration commands")
Cc: cristian.dumitrescu@intel.com

Signed-off-by: Churchill Khangar <churchill.khangar@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/pipeline/cli.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon March 24, 2021, 9:05 a.m. UTC | #1
05/03/2021 16:15, Churchill Khangar:
> This patch addresses the issue with strtoul base

Which issue?
Please explain what is broken and how it is fixed.
Cristian Dumitrescu March 24, 2021, 10:41 a.m. UTC | #2
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, March 24, 2021 9:05 AM
> To: Khangar, Churchill <churchill.khangar@intel.com>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; P,
> Venkata Suresh Kumar <venkata.suresh.kumar.p@intel.com>; Jangra,
> Yogesh <yogesh.jangra@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base
> 
> 05/03/2021 16:15, Churchill Khangar:
> > This patch addresses the issue with strtoul base
> 
> Which issue?
> Please explain what is broken and how it is fixed.
> 
> 

Nothing is broken here, this is incorrectly labeled as a fix. This is simply an small improvement to allow specification of integer arguments for the CLI commands in hexadecimal ( and octal :) ) as well as decimal, as opposed to just decimal.

Churchill, it would be great if you could update the title and description to reflect this as opposed to claiming a fix, and send v2, thanks!

Regards,
Cristian
diff mbox series

Patch

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index e97e120..631c325 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -53,7 +53,7 @@ 
 	if (!isdigit(*p))
 		return -EINVAL;
 
-	val = strtoul(p, &next, 10);
+	val = strtoul(p, &next, 0);
 	if (p == next)
 		return -EINVAL;