diff mbox series

[v2] doc: fix testpmd sample qinq flow rules

Message ID 1611061252-19605-1-git-send-email-bernard.iremonger@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series [v2] doc: fix testpmd sample qinq flow rules | expand

Checks

Context Check Description
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Bernard Iremonger Jan. 19, 2021, 1 p.m. UTC
In the Testpmd Flow rules management section, correct
the TPID values in the Sample QinQ flow rules sub section.
Also replace the keyword qinq_strip with extend in the
vlan set command.

Fixes: bef3bfe7d5f4 ("doc: revise sample testpmd flow commands")
Cc: stable@dpdk.org

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Xiaoyun Li Jan. 20, 2021, 1:42 a.m. UTC | #1
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

> -----Original Message-----
> From: Iremonger, Bernard <bernard.iremonger@intel.com>
> Sent: Tuesday, January 19, 2021 21:01
> To: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] doc: fix testpmd sample qinq flow rules
> 
> In the Testpmd Flow rules management section, correct the TPID values in the
> Sample QinQ flow rules sub section.
> Also replace the keyword qinq_strip with extend in the vlan set command.
> 
> Fixes: bef3bfe7d5f4 ("doc: revise sample testpmd flow commands")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 9be4500..6a00245 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4426,14 +4426,14 @@ Sample QinQ flow rules  Before creating QinQ
> rule(s) the following commands should be issued to enable QinQ::
> 
>     testpmd> port stop 0
> -   testpmd> vlan set qinq_strip on 0
> +   testpmd> vlan set extend on 0
> 
>  The above command sets the inner and outer TPID's to 0x8100.
> 
>  To change the TPID's the following commands should be used::
> 
> -   testpmd> vlan set outer tpid 0xa100 0
> -   testpmd> vlan set inner tpid 0x9100 0
> +   testpmd> vlan set outer tpid 0x88A8 0
> +   testpmd> vlan set inner tpid 0x8100 0
>     testpmd> port start 0
> 
>  Validate and create a QinQ rule on port 0 to steer traffic to a VF queue in a VM.
> --
> 2.7.4
Ferruh Yigit Feb. 2, 2021, 9:59 a.m. UTC | #2
On 1/20/2021 1:42 AM, Li, Xiaoyun wrote:

>> -----Original Message-----
>> From: Iremonger, Bernard <bernard.iremonger@intel.com>
>> Sent: Tuesday, January 19, 2021 21:01
>> To: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
>> Subject: [PATCH v2] doc: fix testpmd sample qinq flow rules
>>
>> In the Testpmd Flow rules management section, correct the TPID values in the
>> Sample QinQ flow rules sub section.
>> Also replace the keyword qinq_strip with extend in the vlan set command.
>>
>> Fixes: bef3bfe7d5f4 ("doc: revise sample testpmd flow commands")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
 >
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 9be4500..6a00245 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -4426,14 +4426,14 @@  Sample QinQ flow rules
 Before creating QinQ rule(s) the following commands should be issued to enable QinQ::
 
    testpmd> port stop 0
-   testpmd> vlan set qinq_strip on 0
+   testpmd> vlan set extend on 0
 
 The above command sets the inner and outer TPID's to 0x8100.
 
 To change the TPID's the following commands should be used::
 
-   testpmd> vlan set outer tpid 0xa100 0
-   testpmd> vlan set inner tpid 0x9100 0
+   testpmd> vlan set outer tpid 0x88A8 0
+   testpmd> vlan set inner tpid 0x8100 0
    testpmd> port start 0
 
 Validate and create a QinQ rule on port 0 to steer traffic to a VF queue in a VM.