diff mbox series

[v5,3/9] ethdev: support new VF representor syntax

Message ID 1611040501-11666-3-git-send-email-xuemingl@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers show
Series [v5,1/9] ethdev: introduce representor type | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Xueming Li Jan. 19, 2021, 7:14 a.m. UTC 
Current VF representor syntax:
 representor=2          - single representor
 representor=[0-3]      - single range

To prepare for more representor types, this patch adds compatible VF
representor devargs syntax:

vf#:
 representor=vf2          - single representor
 representor=vf[1,3,5]    - single list
 representor=vf[0-3]      - single range
 representor=vf[0,1,4-7]  - list with singles and range

For backwards compatibility, representor "#" is interpreted as "vf#".

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/prog_guide/poll_mode_drv.rst | 7 ++++---
 lib/librte_ethdev/ethdev_private.c      | 5 ++++-
 2 files changed, 8 insertions(+), 4 deletions(-)

Comments

Andrew Rybchenko Jan. 19, 2021, 7:51 a.m. UTC | #1 
On 1/19/21 10:14 AM, Xueming Li wrote:
> Current VF representor syntax:
>  representor=2          - single representor
>  representor=[0-3]      - single range
> 
> To prepare for more representor types, this patch adds compatible VF
> representor devargs syntax:
> 
> vf#:
>  representor=vf2          - single representor
>  representor=vf[1,3,5]    - single list
>  representor=vf[0-3]      - single range
>  representor=vf[0,1,4-7]  - list with singles and range
> 
> For backwards compatibility, representor "#" is interpreted as "vf#".
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
diff mbox series

Patch

diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst
index 239ec820ea..0117c2af07 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -374,9 +374,10 @@  parameters to those ports.
   this argument allows user to specify which switch ports to enable port
   representors for.::
 
-   -a DBDF,representor=0
-   -a DBDF,representor=[0,4,6,9]
-   -a DBDF,representor=[0-31]
+   -a DBDF,representor=vf0
+   -a DBDF,representor=vf[0,4,6,9]
+   -a DBDF,representor=vf[0-31]
+   -a DBDF,representor=vf[0,2-4,7,9-11]
 
 Note: PMDs are not required to support the standard device arguments and users
 should consult the relevant PMD documentation to see support devargs.
diff --git a/lib/librte_ethdev/ethdev_private.c b/lib/librte_ethdev/ethdev_private.c
index e87636f665..20e48a48be 100644
--- a/lib/librte_ethdev/ethdev_private.c
+++ b/lib/librte_ethdev/ethdev_private.c
@@ -119,7 +119,8 @@  rte_eth_devargs_process_list(char *str, uint16_t *list, uint16_t *len_list,
  * Parse representor ports from a single value or lists.
  *
  * Representor format:
- *   #: range or single number of VF representor
+ *   #: range or single number of VF representor - legacy
+ *   vf#: VF port representor/s
  *
  * Examples of #:
  *  2               - single
@@ -132,6 +133,8 @@  rte_eth_devargs_parse_representor_ports(char *str, void *data)
 	struct rte_eth_devargs *eth_da = data;
 
 	eth_da->type = RTE_ETH_REPRESENTOR_VF;
+	if (str[0] == 'v' && str[1] == 'f')
+		str += 2;
 	str = rte_eth_devargs_process_list(str, eth_da->representor_ports,
 		&eth_da->nb_representor_ports, RTE_MAX_ETHPORTS);
 	if (str == NULL)