diff mbox series

metrics/windows: build rte_metrics library

Message ID 1610408246-29482-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Superseded, archived
Headers show
Series metrics/windows: build rte_metrics library | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

Tyler Retzlaff Jan. 11, 2021, 11:37 p.m. UTC
From: Tyler Retzlaff <roretzla@microsoft.com>

declare reduced set of exports for rte_metrics on windows and include
it in the set of libraries to build and install.

rte_metrics_tel* exports depend on conditionally available component.
this change minimally allows enabling the building of rte_metrics on
windows.

Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
---
 lib/librte_metrics/rte_metrics_exports.def | 8 ++++++++
 lib/meson.build                            | 1 +
 2 files changed, 9 insertions(+)
 create mode 100644 lib/librte_metrics/rte_metrics_exports.def

Comments

Dmitry Kozlyuk Jan. 12, 2021, 1:15 a.m. UTC | #1
+ Pallavi, Khoa

On Mon, 11 Jan 2021 15:37:26 -0800, Tyler Retzlaff wrote:
> From: Tyler Retzlaff <roretzla@microsoft.com>
> 
> declare reduced set of exports for rte_metrics on windows and include
> it in the set of libraries to build and install.
> 
> rte_metrics_tel* exports depend on conditionally available component.
> this change minimally allows enabling the building of rte_metrics on
> windows.

What's the future plan? Once we talked about a script that would inspect
objects and filter missing functions from the list in .map to build .def. Is
MSFT working on it? Or do we choose another way?

> --- /dev/null
> +++ b/lib/librte_metrics/rte_metrics_exports.def
> @@ -0,0 +1,8 @@
> +EXPORTS
> +	rte_metrics_get_names
> +	rte_metrics_get_values
> +	rte_metrics_init

+ rte_metrics_deinit

> +	rte_metrics_reg_name
> +	rte_metrics_reg_names
> +	rte_metrics_update_value
> +	rte_metrics_update_values
Tyler Retzlaff Jan. 12, 2021, 1:32 a.m. UTC | #2
On Tue, Jan 12, 2021 at 04:15:34AM +0300, Dmitry Kozlyuk wrote:
> + Pallavi, Khoa
> 
> What's the future plan? Once we talked about a script that would inspect
> objects and filter missing functions from the list in .map to build .def. Is
> MSFT working on it? Or do we choose another way?

MSFT has a task tracking work to resolve this. We agree it is cumbersome to
try and keep the .map and .def files in sync by hand.
Tal Shnaiderman Jan. 12, 2021, 6:44 a.m. UTC | #3
> Subject: Re: [dpdk-dev] [PATCH] metrics/windows: build rte_metrics library
> 
> On Tue, Jan 12, 2021 at 04:15:34AM +0300, Dmitry Kozlyuk wrote:
> > + Pallavi, Khoa
> >
> > What's the future plan? Once we talked about a script that would
> > inspect objects and filter missing functions from the list in .map to
> > build .def. Is MSFT working on it? Or do we choose another way?
> 
> MSFT has a task tracking work to resolve this. We agree it is cumbersome to
> try and keep the .map and .def files in sync by hand.

Is there a DD to complete this task? Dmitry already sent an email with the details on how to resolve it using DUMPBIN.
diff mbox series

Patch

diff --git a/lib/librte_metrics/rte_metrics_exports.def b/lib/librte_metrics/rte_metrics_exports.def
new file mode 100644
index 000000000..40ec342a0
--- /dev/null
+++ b/lib/librte_metrics/rte_metrics_exports.def
@@ -0,0 +1,8 @@ 
+EXPORTS
+	rte_metrics_get_names
+	rte_metrics_get_values
+	rte_metrics_init
+	rte_metrics_reg_name
+	rte_metrics_reg_names
+	rte_metrics_update_value
+	rte_metrics_update_values
diff --git a/lib/meson.build b/lib/meson.build
index ed00f8914..845397fba 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -45,6 +45,7 @@  if is_windows
 		'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci',
 		'cmdline',
 		'hash',
+		'metrics',
 	] # only supported libraries for windows
 endif