diff mbox series

[4/4] vdpa/mlx5: set default event mode to polling

Message ID 1606952203-23310-4-git-send-email-xuemingl@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers show
Series [1/4] vdpa/mlx5: set polling mode default delay to zero | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Xueming(Steven) Li Dec. 2, 2020, 11:36 p.m. UTC
For better performance and latency, this patch sets default event
handling mode to polling mode which uses dedicate thread per device to
poll and process event.

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/vdpadevs/mlx5.rst  | 2 +-
 drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Maxime Coquelin Jan. 7, 2021, 10:34 a.m. UTC | #1
On 12/3/20 12:36 AM, Xueming Li wrote:
> For better performance and latency, this patch sets default event
> handling mode to polling mode which uses dedicate thread per device to
> poll and process event.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/vdpadevs/mlx5.rst  | 2 +-
>  drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst
> index 20254257c9..730e171ba3 100644
> --- a/doc/guides/vdpadevs/mlx5.rst
> +++ b/doc/guides/vdpadevs/mlx5.rst
> @@ -116,7 +116,7 @@ Driver options
>    - 2, Completion queue scheduling will be managed by interrupts. Each CQ burst
>      arms the CQ in order to get an interrupt event in the next traffic burst.
>  
> -  - Default mode is 0.
> +  - Default mode is 1.
>  
>  - ``event_us`` parameter [int]
>  
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
> index 1f92c529c9..5d954d48ce 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
> @@ -647,7 +647,7 @@ mlx5_vdpa_config_get(struct rte_devargs *devargs, struct mlx5_vdpa_priv *priv)
>  {
>  	struct rte_kvargs *kvlist;
>  
> -	priv->event_mode = MLX5_VDPA_EVENT_MODE_DYNAMIC_TIMER;
> +	priv->event_mode = MLX5_VDPA_EVENT_MODE_FIXED_TIMER;
>  	priv->event_us = 0;
>  	priv->event_core = -1;
>  	priv->no_traffic_time_s = MLX5_VDPA_DEFAULT_NO_TRAFFIC_TIME_S;
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin Jan. 8, 2021, 9:13 a.m. UTC | #2
On 12/3/20 12:36 AM, Xueming Li wrote:
> For better performance and latency, this patch sets default event
> handling mode to polling mode which uses dedicate thread per device to
> poll and process event.
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/vdpadevs/mlx5.rst  | 2 +-
>  drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Series applied to dpdk-next-virtio/main.

Thanks,
Maxime
diff mbox series

Patch

diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst
index 20254257c9..730e171ba3 100644
--- a/doc/guides/vdpadevs/mlx5.rst
+++ b/doc/guides/vdpadevs/mlx5.rst
@@ -116,7 +116,7 @@  Driver options
   - 2, Completion queue scheduling will be managed by interrupts. Each CQ burst
     arms the CQ in order to get an interrupt event in the next traffic burst.
 
-  - Default mode is 0.
+  - Default mode is 1.
 
 - ``event_us`` parameter [int]
 
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
index 1f92c529c9..5d954d48ce 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
@@ -647,7 +647,7 @@  mlx5_vdpa_config_get(struct rte_devargs *devargs, struct mlx5_vdpa_priv *priv)
 {
 	struct rte_kvargs *kvlist;
 
-	priv->event_mode = MLX5_VDPA_EVENT_MODE_DYNAMIC_TIMER;
+	priv->event_mode = MLX5_VDPA_EVENT_MODE_FIXED_TIMER;
 	priv->event_us = 0;
 	priv->event_core = -1;
 	priv->no_traffic_time_s = MLX5_VDPA_DEFAULT_NO_TRAFFIC_TIME_S;