diff mbox series

net/mlx5: reduce log level in hlist registration

Message ID 1606147002-451248-1-git-send-email-matan@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series net/mlx5: reduce log level in hlist registration | expand

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-testing warning Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional fail Functional Testing issues
ci/checkpatch success coding style OK

Commit Message

Matan Azrad Nov. 23, 2020, 3:56 p.m. UTC
In mlx5 internal hash list tool, there is a log print when an entry
allocation is failed: Can't allocate hash list entry.

Some initialization checks triggers hash list registration in order to
check some capabilities. Here, the failure in registration doesn't
lead to failure in the initialization flow, that is why the log level
can be lower.

Move the entry allocation failure log to debug level.

Signed-off-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/mlx5_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Asaf Penso Nov. 23, 2020, 4:01 p.m. UTC | #1
Regards,
Asaf Penso

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
>Sent: Monday, November 23, 2020 5:57 PM
>To: Slava Ovsiienko <viacheslavo@nvidia.com>
>Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
>Subject: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
>
>In mlx5 internal hash list tool, there is a log print when an entry allocation is
>failed: Can't allocate hash list entry.
>
>Some initialization checks triggers hash list registration in order to check some
>capabilities. Here, the failure in registration doesn't lead to failure in the
>initialization flow, that is why the log level can be lower.
>
>Move the entry allocation failure log to debug level.
>
>Signed-off-by: Matan Azrad <matan@nvidia.com>
Reviewed-by: Asaf Penso <asafp@nvidia.com>

>---
> drivers/net/mlx5/mlx5_utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
>index 9889437..848d108 100644
>--- a/drivers/net/mlx5/mlx5_utils.c
>+++ b/drivers/net/mlx5/mlx5_utils.c
>@@ -156,7 +156,7 @@ struct mlx5_hlist_entry*
> 	entry = h->cb_create(h, key, ctx);
> 	if (!entry) {
> 		rte_errno = ENOMEM;
>-		DRV_LOG(ERR, "Can't allocate hash list %s entry.", h->name);
>+		DRV_LOG(DEBUG, "Can't allocate hash list %s entry.", h-
>>name);
> 		goto done;
> 	}
> 	entry->key = key;
>--
>1.8.3.1
Viacheslav Ovsiienko Nov. 23, 2020, 9:47 p.m. UTC | #2
> -----Original Message-----
> From: Matan Azrad <matan@nvidia.com>
> Sent: Monday, November 23, 2020 17:57
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
> Subject: [PATCH] net/mlx5: reduce log level in hlist registration
> 
> In mlx5 internal hash list tool, there is a log print when an entry allocation is
> failed: Can't allocate hash list entry.
> 
> Some initialization checks triggers hash list registration in order to check some
> capabilities. Here, the failure in registration doesn't lead to failure in the
> initialization flow, that is why the log level can be lower.
> 
> Move the entry allocation failure log to debug level.
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Thomas Monjalon Nov. 24, 2020, 10:29 p.m. UTC | #3
> > In mlx5 internal hash list tool, there is a log print when an entry allocation is
> > failed: Can't allocate hash list entry.
> > 
> > Some initialization checks triggers hash list registration in order to check some
> > capabilities. Here, the failure in registration doesn't lead to failure in the
> > initialization flow, that is why the log level can be lower.
> > 
> > Move the entry allocation failure log to debug level.
> > 
> > Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
index 9889437..848d108 100644
--- a/drivers/net/mlx5/mlx5_utils.c
+++ b/drivers/net/mlx5/mlx5_utils.c
@@ -156,7 +156,7 @@  struct mlx5_hlist_entry*
 	entry = h->cb_create(h, key, ctx);
 	if (!entry) {
 		rte_errno = ENOMEM;
-		DRV_LOG(ERR, "Can't allocate hash list %s entry.", h->name);
+		DRV_LOG(DEBUG, "Can't allocate hash list %s entry.", h->name);
 		goto done;
 	}
 	entry->key = key;