From patchwork Mon Nov 16 17:40:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Timothy McDaniel X-Patchwork-Id: 84247 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15E31A04B5; Mon, 16 Nov 2020 18:39:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B21C2C8B0; Mon, 16 Nov 2020 18:39:39 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D980A323E for ; Mon, 16 Nov 2020 18:39:37 +0100 (CET) IronPort-SDR: Tc36GzibcSiyIvM0UWTy9DMXz7hG3Jctn6babTs9HMuY51HfLk//4VY08DvEOXKomqzVb8jjyi 4wVCaBOuN/5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="150633217" X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="150633217" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 09:39:16 -0800 IronPort-SDR: B8kqqIP9CHghPefhyhU/MekGzMCxkg2fzftUsMjqE5KYC8fXRWI1Zpvx7R6XnkU8Ectar8iyHS dtlYH4y2PRPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="475607192" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by orsmga004.jf.intel.com with ESMTP; 16 Nov 2020 09:39:15 -0800 From: Timothy McDaniel To: Cc: dev@dpdk.org, erik.g.carrillo@intel.com, gage.eads@intel.com, harry.van.haaren@intel.com, jerinj@marvell.com, thomas@monjalon.net Date: Mon, 16 Nov 2020 11:40:38 -0600 Message-Id: <1605548439-31240-1-git-send-email-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 1.7.10 Subject: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add NULL check before using t->mbuf_pool. Coverity issue: 363719 Fixes: 83326 ("event/dlb: add PMD self-tests") Signed-off-by: Timothy McDaniel Acked-by: John McNamara --- drivers/event/dlb/dlb_selftest.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/event/dlb/dlb_selftest.c b/drivers/event/dlb/dlb_selftest.c index b9ef778c1..8ab00ba87 100644 --- a/drivers/event/dlb/dlb_selftest.c +++ b/drivers/event/dlb/dlb_selftest.c @@ -202,7 +202,12 @@ test_stop_flush(struct test *t) /* test to check we can properly flush events */ goto err; } - count = rte_mempool_avail_count(t->mbuf_pool); + if (t->mbuf_pool) + count = rte_mempool_avail_count(t->mbuf_pool); + else { + printf("%d: mbuf_pool is NULL\n", __LINE__); + goto err; + } if (rte_event_port_attr_get(evdev, 0,