diff mbox series

event/dlb: do not free memzone if port create succeeds

Message ID 1605126422-522-3-git-send-email-timothy.mcdaniel@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series event/dlb: do not free memzone if port create succeeds |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot warning Travis build: failed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Timothy McDaniel Nov. 11, 2020, 8:27 p.m. UTC 
  Add missing returns so that the memzone free is not called if
port create is successful.

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 drivers/event/dlb/pf/dlb_pf.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chen, Mike Ximing Nov. 11, 2020, 9:04 p.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Timothy McDaniel
> Sent: Wednesday, November 11, 2020 3:27 PM
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> jerinj@marvell.com; thomas@monjalon.net; david.marchand@redhat.com
> Subject: [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create
> succeeds
> 
> Add missing returns so that the memzone free is not called if port create is
> successful.
> 
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
>  drivers/event/dlb/pf/dlb_pf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/event/dlb/pf/dlb_pf.c b/drivers/event/dlb/pf/dlb_pf.c index
> cf88c49..3aeef6f 100644
> --- a/drivers/event/dlb/pf/dlb_pf.c
> +++ b/drivers/event/dlb/pf/dlb_pf.c
> @@ -342,6 +342,7 @@ dlb_pf_ldb_port_create(struct dlb_hw_dev *handle,
>  	*(struct dlb_cmd_response *)cfg->response = response;
> 
>  	DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, ret);
> +	return 0;
> 
>  create_port_err:
> 
> @@ -419,6 +420,7 @@ dlb_pf_dir_port_create(struct dlb_hw_dev *handle,
>  	*(struct dlb_cmd_response *)cfg->response = response;
> 
>  	DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, ret);
> +	return 0;
> 
>  create_port_err:
> 
> --
> 2.6.4

Reviewed-by: Mike Ximing Chen <mike.ximing.chen@intel.com>
diff mbox series

Patch

diff --git a/drivers/event/dlb/pf/dlb_pf.c b/drivers/event/dlb/pf/dlb_pf.c
index cf88c49..3aeef6f 100644
--- a/drivers/event/dlb/pf/dlb_pf.c
+++ b/drivers/event/dlb/pf/dlb_pf.c
@@ -342,6 +342,7 @@  dlb_pf_ldb_port_create(struct dlb_hw_dev *handle,
 	*(struct dlb_cmd_response *)cfg->response = response;
 
 	DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, ret);
+	return 0;
 
 create_port_err:
 
@@ -419,6 +420,7 @@  dlb_pf_dir_port_create(struct dlb_hw_dev *handle,
 	*(struct dlb_cmd_response *)cfg->response = response;
 
 	DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, ret);
+	return 0;
 
 create_port_err: