diff mbox series

[prefix=DPDK_KMODS,v6,2/2] linux/igb_uio: add Makefile to build the igb_uio module

Message ID 1604002251-43812-2-git-send-email-hariprasad.govindharajan@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series [prefix=DPDK_KMODS,v6,1/2] linux/igb_uio: remove DPDK dependency for building igb_uio | expand

Checks

Context Check Description
ci/Intel-compilation fail apply issues
ci/checkpatch success coding style OK

Commit Message

Hariprasad Govindharajan Oct. 29, 2020, 8:10 p.m. UTC
With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Since there is no more dependency on DPDK headers, this module can be
built simply by running make in the source dir

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v6:
split the patch into two patches to create a patchset
v5:
Removed the DPDK dependency
v4:
Corrected the indentation
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

Comments

Ferruh Yigit Oct. 29, 2020, 8:17 p.m. UTC | #1
On 10/29/2020 8:10 PM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Since there is no more dependency on DPDK headers, this module can be
> built simply by running make in the source dir
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon Oct. 29, 2020, 9:16 p.m. UTC | #2
29/10/2020 21:10, Hariprasad Govindharajan:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.

Please don't justify the use of igb_uio here.
(and I think it's wrong, you can always use VFIO except on very old kernels)

> Since there is no more dependency on DPDK headers, this module can be
> built simply by running make in the source dir

No need to talk about the old dependency here.
diff mbox series

Patch

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..09ae5d9
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,7 @@ 
+KSRC ?= /lib/modules/`uname -r`/build
+
+all:
+	make -C $(KSRC)/ M=$(PWD)
+
+clean:
+	make -C $(KSRC)/ M=$(PWD) clean