| Message ID | 1591871065-12461-1-git-send-email-phil.yang@arm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Marchand |
| Headers | show |
| Series | [1/2] eal: remove redundant code | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-testing | success | Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-nxp-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/checkpatch | success | coding style OK |
<snip> > Subject: [PATCH 1/2] eal: remove redundant code > > The event status has been cleaned up by the CAS operation when we free > the event data, so there is no need to set it to invalid after that. > > Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt") > Cc: shahafs@mellanox.com > Cc: stable@dpdk.org This is not a bug fix. I think it is not worth backporting, suggest removing this. > > Signed-off-by: Phil Yang <phil.yang@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> Otherwise Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > --- > lib/librte_eal/linux/eal_interrupts.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > b/lib/librte_eal/linux/eal_interrupts.c > index 16e7a7d..2f369dc 100644 > --- a/lib/librte_eal/linux/eal_interrupts.c > +++ b/lib/librte_eal/linux/eal_interrupts.c > @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle > *intr_handle) > if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) { > /* force free if the entry valid */ > eal_epoll_data_safe_free(rev); > - rev->status = RTE_EPOLL_INVALID; > } > } > } > -- > 2.7.4
> -----Original Message----- > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> > Sent: Wednesday, July 8, 2020 1:15 PM > To: Phil Yang <Phil.Yang@arm.com>; dev@dpdk.org > Cc: drc@linux.vnet.ibm.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; nd > <nd@arm.com>; shahafs@mellanox.com; stable@dpdk.org; Honnappa > Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com> > Subject: RE: [PATCH 1/2] eal: remove redundant code > > <snip> > > > Subject: [PATCH 1/2] eal: remove redundant code > > > > The event status has been cleaned up by the CAS operation when we free > > the event data, so there is no need to set it to invalid after that. > > > > Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt") > > Cc: shahafs@mellanox.com > > Cc: stable@dpdk.org > This is not a bug fix. I think it is not worth backporting, suggest removing this. OK. > > > > > Signed-off-by: Phil Yang <phil.yang@arm.com> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > Otherwise > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > > > --- > > lib/librte_eal/linux/eal_interrupts.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > b/lib/librte_eal/linux/eal_interrupts.c > > index 16e7a7d..2f369dc 100644 > > --- a/lib/librte_eal/linux/eal_interrupts.c > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle > > *intr_handle) > > if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) { > > /* force free if the entry valid */ > > eal_epoll_data_safe_free(rev); > > - rev->status = RTE_EPOLL_INVALID; > > } > > } > > } > > -- > > 2.7.4
diff --git a/lib/librte_eal/linux/eal_interrupts.c b/lib/librte_eal/linux/eal_interrupts.c index 16e7a7d..2f369dc 100644 --- a/lib/librte_eal/linux/eal_interrupts.c +++ b/lib/librte_eal/linux/eal_interrupts.c @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) { /* force free if the entry valid */ eal_epoll_data_safe_free(rev); - rev->status = RTE_EPOLL_INVALID; } } }
The event status has been cleaned up by the CAS operation when we free the event data, so there is no need to set it to invalid after that. Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt") Cc: shahafs@mellanox.com Cc: stable@dpdk.org Signed-off-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> --- lib/librte_eal/linux/eal_interrupts.c | 1 - 1 file changed, 1 deletion(-)