Currently, rte flow with RSS action may have different queue number. The
indexed memory pool is not suitable for the flow with RSS action.
For flows without RSS action, the size are fixed. Allocate the none RSS
rte flow memory from indexed memory pool helps save MALLOC_ELEM_OVERHEAD
which is more than 64 bytes for rte flow.
Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 10 ++++++++++
drivers/net/mlx5/mlx5.h | 1 +
drivers/net/mlx5/mlx5_flow.c | 24 ++++++++++++++++++------
drivers/net/mlx5/mlx5_flow.h | 1 +
4 files changed, 30 insertions(+), 6 deletions(-)
@@ -277,6 +277,16 @@ struct mlx5_dev_spawn_data {
.free = rte_free,
.type = "mlx5_flow_handle_ipool",
},
+ {
+ .size = (sizeof(struct rte_flow) +
+ RTE_ALIGN_CEIL(sizeof(uint16_t), sizeof(void *))),
+ .trunk_size = 4096,
+ .need_lock = 1,
+ .release_mem_en = 1,
+ .malloc = rte_malloc_socket,
+ .free = rte_free,
+ .type = "rte_flow_ipool",
+ },
};
@@ -61,6 +61,7 @@ enum mlx5_ipool_index {
#endif
MLX5_IPOOL_HRXQ, /* Pool for hrxq resource. */
MLX5_IPOOL_MLX5_FLOW, /* Pool for mlx5 flow handle. */
+ MLX5_IPOOL_RTE_FLOW, /* Pool for rte_flow. */
MLX5_IPOOL_MAX,
};
@@ -4225,6 +4225,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,
struct mlx5_flow_rss_meta *rss_meta = priv->rss_meta;
const struct rte_flow_action *p_actions_rx = actions;
uint32_t i;
+ uint32_t idx = 0;
uint32_t flow_size;
int hairpin_flow = 0;
uint32_t hairpin_id = 0;
@@ -4247,17 +4248,21 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,
}
flow_size = sizeof(struct rte_flow);
rss = flow_get_rss_action(p_actions_rx);
- if (rss)
+ if (rss) {
flow_size += RTE_ALIGN_CEIL(rss->queue_num * sizeof(uint16_t),
sizeof(void *));
- else
- flow_size += RTE_ALIGN_CEIL(sizeof(uint16_t), sizeof(void *));
- flow = rte_calloc(__func__, 1, flow_size, 0);
+ flow = rte_calloc(__func__, 1, flow_size, 0);
+ } else {
+ flow = mlx5_ipool_zmalloc(priv->sh->ipool[MLX5_IPOOL_RTE_FLOW],
+ &idx);
+ }
if (!flow) {
rte_errno = ENOMEM;
goto error_before_flow;
}
flow->drv_type = flow_get_drv_type(dev, attr);
+ if (idx)
+ flow->idx = idx;
if (hairpin_id != 0)
flow->hairpin_flow_id = hairpin_id;
MLX5_ASSERT(flow->drv_type > MLX5_FLOW_TYPE_MIN &&
@@ -4368,7 +4373,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,
ret = rte_errno; /* Save rte_errno before cleanup. */
flow_mreg_del_copy_action(dev, flow);
flow_drv_destroy(dev, flow);
- rte_free(flow);
+ if (idx)
+ mlx5_ipool_free(priv->sh->ipool[MLX5_IPOOL_RTE_FLOW], idx);
+ else
+ rte_free(flow);
rte_errno = ret; /* Restore rte_errno. */
error_before_flow:
ret = rte_errno;
@@ -4492,7 +4500,11 @@ struct rte_flow *
TAILQ_REMOVE(list, flow, next);
flow_mreg_del_copy_action(dev, flow);
rte_free(flow->fdir);
- rte_free(flow);
+ if (flow->idx)
+ mlx5_ipool_free(priv->sh->ipool[MLX5_IPOOL_RTE_FLOW],
+ flow->idx);
+ else
+ rte_free(flow);
}
/**
@@ -765,6 +765,7 @@ struct rte_flow {
struct mlx5_fdir *fdir; /**< Pointer to associated FDIR if any. */
uint32_t hairpin_flow_id; /**< The flow id used for hairpin. */
uint32_t copy_applied:1; /**< The MARK copy Flow os applied. */
+ uint32_t idx; /**< Index to the rte flow allocated from indexed pool. */
};
typedef int (*mlx5_flow_validate_t)(struct rte_eth_dev *dev,