| Message ID | 1579010128-15794-2-git-send-email-bernard.iremonger@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series | net/i40e: ESP support | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | fail | Compilation issues |
| ci/checkpatch | success | coding style OK |
On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > add ITEM_ESP > add ITEM_ESP_SPI > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > Acked-by: Ori Kam <orika@mellanox.com> > --- > app/test-pmd/cmdline_flow.c | 4 +--- > app/test-pmd/config.c | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 9643148..9c6edb8 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -6075,9 +6075,6 @@ cmd_flow_tok(cmdline_parse_token_hdr_t **hdr, > static void > cmd_flow_parsed(const struct buffer *in) > { > - printf("Flow command line parsed successfully for command=%d.\n", > - in->command); > - Hi Bernard, Is this patchset depends another, or can there be something went wrong here, I can't find these lines removed also it is not really clear what this patchset does. > switch (in->command) { > case VALIDATE: > port_flow_validate(in->port, &in->args.vc.attr, > @@ -6261,6 +6258,7 @@ flow_item_default_mask(const struct rte_flow_item *item) > break; > case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: > mask = &rte_flow_item_pppoe_proto_id_mask; > + break; > case RTE_FLOW_ITEM_TYPE_ESP: > mask = &rte_flow_item_esp_mask; > break; > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 2753ec5..d599682 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1303,7 +1303,7 @@ port_flow_complain(struct rte_flow_error *error) > errstr = "unknown type"; > else > errstr = errstrlist[error->type]; > - printf("%s(): Caught PMD error type %d (%s): %s%s: %s\n", __func__, > + printf("Caught error type %d (%s): %s%s: %s\n", > error->type, errstr, > error->cause ? (snprintf(buf, sizeof(buf), "cause: %p, ", > error->cause), buf) : "", >
Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh <ferruh.yigit@intel.com> > Sent: Tuesday, January 14, 2020 7:04 PM > To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org; > Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; > Doherty, Declan <declan.doherty@intel.com> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Byrne, Stephen1 > <stephen1.byrne@intel.com>; Zhang, Helin <helin.zhang@intel.com> > Subject: Re: [dpdk-dev] [PATCH v5 01/14] app/testpmd: parse flow > command line for ESP > > On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > > add ITEM_ESP > > add ITEM_ESP_SPI > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > > Acked-by: Ori Kam <orika@mellanox.com> > > --- > > app/test-pmd/cmdline_flow.c | 4 +--- > > app/test-pmd/config.c | 2 +- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 9643148..9c6edb8 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -6075,9 +6075,6 @@ cmd_flow_tok(cmdline_parse_token_hdr_t > **hdr, > > static void cmd_flow_parsed(const struct buffer *in) { > > - printf("Flow command line parsed successfully for > command=%d.\n", > > - in->command); > > - > > Hi Bernard, > > Is this patchset depends another, or can there be something went wrong > here, I can't find these lines removed also it is not really clear what this > patchset does. Something has gone wrong here. I will investigate. > > > switch (in->command) { > > case VALIDATE: > > port_flow_validate(in->port, &in->args.vc.attr, @@ -6261,6 > +6258,7 > > @@ flow_item_default_mask(const struct rte_flow_item *item) > > break; > > case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: > > mask = &rte_flow_item_pppoe_proto_id_mask; > > + break; > > case RTE_FLOW_ITEM_TYPE_ESP: > > mask = &rte_flow_item_esp_mask; > > break; > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > 2753ec5..d599682 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -1303,7 +1303,7 @@ port_flow_complain(struct rte_flow_error > *error) > > errstr = "unknown type"; > > else > > errstr = errstrlist[error->type]; > > - printf("%s(): Caught PMD error type %d (%s): %s%s: %s\n", > __func__, > > + printf("Caught error type %d (%s): %s%s: %s\n", > > error->type, errstr, > > error->cause ? (snprintf(buf, sizeof(buf), "cause: %p, ", > > error->cause), buf) : "", > > Regards, Bernard
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 9643148..9c6edb8 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -6075,9 +6075,6 @@ cmd_flow_tok(cmdline_parse_token_hdr_t **hdr, static void cmd_flow_parsed(const struct buffer *in) { - printf("Flow command line parsed successfully for command=%d.\n", - in->command); - switch (in->command) { case VALIDATE: port_flow_validate(in->port, &in->args.vc.attr, @@ -6261,6 +6258,7 @@ flow_item_default_mask(const struct rte_flow_item *item) break; case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: mask = &rte_flow_item_pppoe_proto_id_mask; + break; case RTE_FLOW_ITEM_TYPE_ESP: mask = &rte_flow_item_esp_mask; break; diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 2753ec5..d599682 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1303,7 +1303,7 @@ port_flow_complain(struct rte_flow_error *error) errstr = "unknown type"; else errstr = errstrlist[error->type]; - printf("%s(): Caught PMD error type %d (%s): %s%s: %s\n", __func__, + printf("Caught error type %d (%s): %s%s: %s\n", error->type, errstr, error->cause ? (snprintf(buf, sizeof(buf), "cause: %p, ", error->cause), buf) : "",