[v1,1/3] drivers: introduce vDPA class
Checks
Commit Message
The vDPA (vhost data path acceleration) drivers provide support for
the vDPA operations introduced by the rte_vhost library.
Any driver which provides the vDPA operations should be moved\added to
the vdpa class under drivers/vdpa/.
Create the general files for vDPA class in drivers and in documentation.
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
doc/guides/index.rst | 1 +
doc/guides/vdpadevs/index.rst | 13 +++++++++++++
drivers/Makefile | 2 ++
drivers/meson.build | 1 +
drivers/vdpa/Makefile | 8 ++++++++
drivers/vdpa/meson.build | 8 ++++++++
6 files changed, 33 insertions(+)
create mode 100644 doc/guides/vdpadevs/index.rst
create mode 100644 drivers/vdpa/Makefile
create mode 100644 drivers/vdpa/meson.build
Comments
Hi Matan,
On 12/25/19 4:19 PM, Matan Azrad wrote:
> The vDPA (vhost data path acceleration) drivers provide support for
> the vDPA operations introduced by the rte_vhost library.
>
> Any driver which provides the vDPA operations should be moved\added to
> the vdpa class under drivers/vdpa/.
>
> Create the general files for vDPA class in drivers and in documentation.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
> doc/guides/index.rst | 1 +
> doc/guides/vdpadevs/index.rst | 13 +++++++++++++
> drivers/Makefile | 2 ++
> drivers/meson.build | 1 +
> drivers/vdpa/Makefile | 8 ++++++++
> drivers/vdpa/meson.build | 8 ++++++++
> 6 files changed, 33 insertions(+)
> create mode 100644 doc/guides/vdpadevs/index.rst
> create mode 100644 drivers/vdpa/Makefile
> create mode 100644 drivers/vdpa/meson.build
>
Looks good to me. Just wondering if we need a dedicated maintainer for
this new class of devices?
Other than that:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
07/01/2020 18:32, Maxime Coquelin:
> Hi Matan,
>
> On 12/25/19 4:19 PM, Matan Azrad wrote:
> > The vDPA (vhost data path acceleration) drivers provide support for
> > the vDPA operations introduced by the rte_vhost library.
> >
> > Any driver which provides the vDPA operations should be moved\added to
> > the vdpa class under drivers/vdpa/.
> >
> > Create the general files for vDPA class in drivers and in documentation.
> >
> > Signed-off-by: Matan Azrad <matan@mellanox.com>
> > ---
> > doc/guides/index.rst | 1 +
> > doc/guides/vdpadevs/index.rst | 13 +++++++++++++
> > drivers/Makefile | 2 ++
> > drivers/meson.build | 1 +
> > drivers/vdpa/Makefile | 8 ++++++++
> > drivers/vdpa/meson.build | 8 ++++++++
> > 6 files changed, 33 insertions(+)
> > create mode 100644 doc/guides/vdpadevs/index.rst
> > create mode 100644 drivers/vdpa/Makefile
> > create mode 100644 drivers/vdpa/meson.build
> >
>
> Looks good to me. Just wondering if we need a dedicated maintainer for
> this new class of devices?
We must create a new section in MAINTAINERS file for vDPA drivers.
Maxime, are you OK to merge those drivers in dpdk-next-virtio tree?
On 1/8/20 10:28 PM, Thomas Monjalon wrote:
> 07/01/2020 18:32, Maxime Coquelin:
>> Hi Matan,
>>
>> On 12/25/19 4:19 PM, Matan Azrad wrote:
>>> The vDPA (vhost data path acceleration) drivers provide support for
>>> the vDPA operations introduced by the rte_vhost library.
>>>
>>> Any driver which provides the vDPA operations should be moved\added to
>>> the vdpa class under drivers/vdpa/.
>>>
>>> Create the general files for vDPA class in drivers and in documentation.
>>>
>>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>>> ---
>>> doc/guides/index.rst | 1 +
>>> doc/guides/vdpadevs/index.rst | 13 +++++++++++++
>>> drivers/Makefile | 2 ++
>>> drivers/meson.build | 1 +
>>> drivers/vdpa/Makefile | 8 ++++++++
>>> drivers/vdpa/meson.build | 8 ++++++++
>>> 6 files changed, 33 insertions(+)
>>> create mode 100644 doc/guides/vdpadevs/index.rst
>>> create mode 100644 drivers/vdpa/Makefile
>>> create mode 100644 drivers/vdpa/meson.build
>>>
>>
>> Looks good to me. Just wondering if we need a dedicated maintainer for
>> this new class of devices?
>
> We must create a new section in MAINTAINERS file for vDPA drivers.
> Maxime, are you OK to merge those drivers in dpdk-next-virtio tree?
Sure, I can do that.
Maxime
@@ -19,6 +19,7 @@ DPDK documentation
bbdevs/index
cryptodevs/index
compressdevs/index
+ vdpadevs/index
eventdevs/index
rawdevs/index
mempool/index
new file mode 100644
@@ -0,0 +1,13 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+ Copyright 2019 Mellanox Technologies, Ltd
+
+vDPA Device Drivers
+===================
+
+The following are a list of vDPA(vhost data path acceleration) device drivers,
+which can be used from an application through vhost API.
+
+.. toctree::
+ :maxdepth: 2
+ :numbered:
+
@@ -18,6 +18,8 @@ DIRS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += common/qat
DEPDIRS-common/qat := bus mempool
DIRS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += compress
DEPDIRS-compress := bus mempool
+DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += vdpa
+DEPDIRS-vdpa := common bus mempool
DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
DEPDIRS-event := common bus mempool net
DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw
@@ -13,6 +13,7 @@ dpdk_driver_classes = ['common',
'raw', # depends on common, bus and net.
'crypto', # depends on common, bus and mempool (net in future).
'compress', # depends on common, bus, mempool.
+ 'vdpa', # depends on common, bus and mempool.
'event', # depends on common, bus, mempool and net.
'baseband'] # depends on common and bus.
new file mode 100644
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2019 Mellanox Technologies, Ltd
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+# DIRS-$(<configuration>) += <directory>
+
+include $(RTE_SDK)/mk/rte.subdir.mk
new file mode 100644
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2019 Mellanox Technologies, Ltd
+
+drivers = []
+std_deps = ['bus_pci', 'kvargs']
+std_deps += ['vhost']
+config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
+driver_name_fmt = 'rte_pmd_@0@'