diff mbox series

[v3,12/12] doc: announce global logs struct removal from ABI

Message ID 1572011772-23271-13-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series EAL and PCI ABI changes for 19.11 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

David Marchand Oct. 25, 2019, 1:56 p.m. UTC 
  New accessor has been introduced to provide the hidden information.
This symbol can now be kept internal.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Anatoly Burakov Oct. 25, 2019, 3:30 p.m. UTC | #1 
On 25-Oct-19 2:56 PM, David Marchand wrote:
> New accessor has been introduced to provide the hidden information.
> This symbol can now be kept internal.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index cf7744e..3aa1634 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -34,6 +34,10 @@ Deprecation Notices
>   
>       + ``rte_eal_devargs_type_count``
>   
> +* eal: The ``rte_logs`` struct and global symbol will be made private to
> +  remove it from the externally visible ABI and allow it to be updated in the
> +  future.
> +
>   * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
>     have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
>     functions.  The due date for the removal targets DPDK 20.02.
> 

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Thomas Monjalon Oct. 25, 2019, 3:33 p.m. UTC | #2 
25/10/2019 15:56, David Marchand:
> New accessor has been introduced to provide the hidden information.
> This symbol can now be kept internal.
[..]
> +* eal: The ``rte_logs`` struct and global symbol will be made private to
> +  remove it from the externally visible ABI and allow it to be updated in the
> +  future.

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Kevin Traynor Oct. 26, 2019, 6:14 p.m. UTC | #3 
On 25/10/2019 14:56, David Marchand wrote:
> New accessor has been introduced to provide the hidden information.
> This symbol can now be kept internal.
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index cf7744e..3aa1634 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -34,6 +34,10 @@ Deprecation Notices
>  
>      + ``rte_eal_devargs_type_count``
>  
> +* eal: The ``rte_logs`` struct and global symbol will be made private to
> +  remove it from the externally visible ABI and allow it to be updated in the
> +  future.
> +
>  * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
>    have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
>    functions.  The due date for the removal targets DPDK 20.02.
> 

Acked-by: Kevin Traynor <ktraynor@redhat.com>
David Marchand Oct. 26, 2019, 6:48 p.m. UTC | #4 
On Sat, Oct 26, 2019 at 8:14 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> On 25/10/2019 14:56, David Marchand wrote:
> > New accessor has been introduced to provide the hidden information.
> > This symbol can now be kept internal.
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index cf7744e..3aa1634 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -34,6 +34,10 @@ Deprecation Notices
> >
> >      + ``rte_eal_devargs_type_count``
> >
> > +* eal: The ``rte_logs`` struct and global symbol will be made private to
> > +  remove it from the externally visible ABI and allow it to be updated in the
> > +  future.
> > +
> >  * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
> >    have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
> >    functions.  The due date for the removal targets DPDK 20.02.
> >
>
> Acked-by: Kevin Traynor <ktraynor@redhat.com>

Thanks Kevin for catching that contrail vrouter relies on rte_logs.
Something to study by 20.11.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index cf7744e..3aa1634 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -34,6 +34,10 @@  Deprecation Notices
 
     + ``rte_eal_devargs_type_count``
 
+* eal: The ``rte_logs`` struct and global symbol will be made private to
+  remove it from the externally visible ABI and allow it to be updated in the
+  future.
+
 * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which
   have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``
   functions.  The due date for the removal targets DPDK 20.02.