From patchwork Wed Oct 23 18:54:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 61783 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C32B11C440; Wed, 23 Oct 2019 20:54:52 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id C939D1C2B8 for ; Wed, 23 Oct 2019 20:54:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571856888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OcXTvxCMrU2lMTlcxeViUI6FyPWdXnUAJ5C6XYBnmXs=; b=hNdPGJkDA7WZdLBjFt6uAGBh6LZBC5kDeRBESJzKZnipvGLoSrxh5AYgDdOf4K4JLKi7dv tN9pidaYeFLlgyLrJhiv+bCNkkzkIOb5zNG9B38hV2APC/sPiP8gCro9x0TK0orBqJgoAu 89d9x0CfxQbQGwfGQYsemeG5y1VLJug= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-DBHPUN4YPeWyY70XDWJHQg-1; Wed, 23 Oct 2019 14:54:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6C6780183E; Wed, 23 Oct 2019 18:54:43 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com [10.40.204.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C48F60624; Wed, 23 Oct 2019 18:54:40 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stephen@networkplumber.org, anatoly.burakov@intel.com, thomas@monjalon.net, Neil Horman , John McNamara , Marko Kovacevic Date: Wed, 23 Oct 2019 20:54:14 +0200 Message-Id: <1571856864-8779-3-git-send-email-david.marchand@redhat.com> In-Reply-To: <1571856864-8779-1-git-send-email-david.marchand@redhat.com> References: <1571736761-32134-1-git-send-email-david.marchand@redhat.com> <1571856864-8779-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: DBHPUN4YPeWyY70XDWJHQg-1 X-Mimecast-Spam-Score: 0 Subject: [dpdk-dev] [PATCH v2 02/12] eal: remove deprecated CPU flags check function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove rte_cpu_check_supported as announced previously. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_19_11.rst | 3 +++ lib/librte_eal/common/eal_common_cpuflags.c | 11 ----------- lib/librte_eal/common/include/generic/rte_cpuflags.h | 9 --------- lib/librte_eal/rte_eal_version.map | 1 - 5 files changed, 3 insertions(+), 24 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e4a33e0..50ac348 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -34,9 +34,6 @@ Deprecation Notices + ``rte_eal_devargs_type_count`` -* eal: The ``rte_cpu_check_supported`` function has been deprecated since - v17.08 and will be removed. - * eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced by ``rte_malloc_virt2iova`` since v17.11 and will be removed. diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst index d7e14b4..8bf2437 100644 --- a/doc/guides/rel_notes/release_19_11.rst +++ b/doc/guides/rel_notes/release_19_11.rst @@ -204,6 +204,9 @@ ABI Changes * eal: made the ``lcore_config`` struct and global symbol private. +* eal: removed the ``rte_cpu_check_supported`` function, replaced by + ``rte_cpu_is_supported`` since dpdk v17.08. + Shared Library Versions ----------------------- diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c index 3a055f7..dc5f75d 100644 --- a/lib/librte_eal/common/eal_common_cpuflags.c +++ b/lib/librte_eal/common/eal_common_cpuflags.c @@ -7,17 +7,6 @@ #include #include -/** - * Checks if the machine is adequate for running the binary. If it is not, the - * program exits with status 1. - */ -void -rte_cpu_check_supported(void) -{ - if (!rte_cpu_is_supported()) - exit(1); -} - int rte_cpu_is_supported(void) { diff --git a/lib/librte_eal/common/include/generic/rte_cpuflags.h b/lib/librte_eal/common/include/generic/rte_cpuflags.h index 156ea00..872f0eb 100644 --- a/lib/librte_eal/common/include/generic/rte_cpuflags.h +++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h @@ -49,15 +49,6 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature); /** * This function checks that the currently used CPU supports the CPU features * that were specified at compile time. It is called automatically within the - * EAL, so does not need to be used by applications. - */ -__rte_deprecated -void -rte_cpu_check_supported(void); - -/** - * This function checks that the currently used CPU supports the CPU features - * that were specified at compile time. It is called automatically within the * EAL, so does not need to be used by applications. This version returns a * result so that decisions may be made (for instance, graceful shutdowns). */ diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index aeedf39..0887549 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -8,7 +8,6 @@ DPDK_2.0 { per_lcore__rte_errno; rte_calloc; rte_calloc_socket; - rte_cpu_check_supported; rte_cpu_get_flag_enabled; rte_cycles_vmware_tsc_map; rte_delay_us;