From patchwork Tue Aug 6 14:56:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Azrad X-Patchwork-Id: 57493 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D31B11B95B; Tue, 6 Aug 2019 16:56:49 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 67C2E1B95B for ; Tue, 6 Aug 2019 16:56:48 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from matan@mellanox.com) with ESMTPS (AES256-SHA encrypted); 6 Aug 2019 17:56:44 +0300 Received: from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx [10.210.16.112]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x76Eud72024099; Tue, 6 Aug 2019 17:56:44 +0300 From: Matan Azrad To: dev@dpdk.org Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Konstantin Ananyev , Olivier Matz Date: Tue, 6 Aug 2019 14:56:23 +0000 Message-Id: <1565103383-23864-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1565103383-23864-1-git-send-email-matan@mellanox.com> References: <1565103383-23864-1-git-send-email-matan@mellanox.com> Subject: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The API breakage is because the ``tso_segsz`` field was documented for LRO. The ``tso_segsz`` field in mbuf indicates the size of each segment in the LRO packet in Rx path and should be provided by the LRO packet port. While the generic LRO packet may aggregate different segments sizes in one packet, it is impossible to expose this information for each segment by one field and it doesn't make sense to expose all the segments sizes in the mbuf. A new field may be added as union with the above field to expose the number of segments aggregated in the LRO packet. Signed-off-by: Matan Azrad Acked-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index c0cd9bc..e826b69 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -45,6 +45,10 @@ Deprecation Notices - ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse`` - ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp`` +* mbuf: Remove ``tso_segsz`` mbuf field providing for LRO support. Use union + block for the field memory to be shared with a new field ``lro_segs_n`` + indicates the number of segments aggregated in the LRO packet. + * dpaa2: removal of ``rte_dpaa2_memsegs`` structure which has been replaced by a pa-va search library. This structure was earlier being used for holding memory segments used by dpaa2 driver for faster pa->va translation. This