buildtools: filter out symbols for ICC
Checks
Commit Message
For some reason, ICC creates additional global symbols with a . which
triggers an error in the check that validates that symbols in the
experimental section are properly published in the map file of the
library. Filter them out.
Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
buildtools/check-experimental-syms.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 7/2/2019 1:13 PM, David Marchand wrote:
> For some reason, ICC creates additional global symbols with a . which
> triggers an error in the check that validates that symbols in the
> experimental section are properly published in the map file of the
> library. Filter them out.
>
> Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
02/07/2019 14:59, Ferruh Yigit:
> On 7/2/2019 1:13 PM, David Marchand wrote:
> > For some reason, ICC creates additional global symbols with a . which
> > triggers an error in the check that validates that symbols in the
> > experimental section are properly published in the map file of the
> > library. Filter them out.
> >
> > Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
> >
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
@@ -36,8 +36,9 @@ do
fi
done
+# Filter out symbols suffixed with a . for icc
for SYM in `objdump -t $OBJFILE |awk '{
- if ($2 != "l" && $4 == ".text.experimental") {
+ if ($2 != "l" && $4 == ".text.experimental" && !($NF ~ /\.$/)) {
print $NF
}
}'`