From patchwork Tue Jun 4 08:59:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 54344 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D76D1BC28; Tue, 4 Jun 2019 11:01:09 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 189101BBD7 for ; Tue, 4 Jun 2019 11:01:07 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 882702E97C8; Tue, 4 Jun 2019 09:01:01 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-116-185.ams2.redhat.com [10.36.116.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABDC95D9CD; Tue, 4 Jun 2019 09:00:59 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, aconole@redhat.com, msantana@redhat.com Date: Tue, 4 Jun 2019 10:59:51 +0200 Message-Id: <1559638792-8608-14-git-send-email-david.marchand@redhat.com> In-Reply-To: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 04 Jun 2019 09:01:01 +0000 (UTC) Subject: [dpdk-dev] [PATCH 13/14] test: do not start tests in parallel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Running the tests in parallel has two drawbacks: - the tests are racing on the hugepages allocations, - the tests are sharing the cores to run their checks which results in undeterministic execution time, This results in random failures. For better reproducibility in CI, start them all in a serialised way. Signed-off-by: David Marchand --- app/test/meson.build | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 212cd1b..f0797c9 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -144,8 +144,7 @@ test_deps = ['acl', 'timer' ] -# All test cases in fast_parallel_test_names list are parallel -fast_parallel_test_names = [ +fast_test_names = [ 'acl_autotest', 'alarm_autotest', 'atomic_autotest', @@ -192,10 +191,6 @@ fast_parallel_test_names = [ 'timer_autotest', 'user_delay_us', 'version_autotest', -] - -# All test cases in fast_non_parallel_test_names list are non-parallel -fast_non_parallel_test_names = [ 'bitratestats_autotest', 'crc_autotest', 'delay_us_sleep_autotest', @@ -219,7 +214,6 @@ fast_non_parallel_test_names = [ 'thash_autotest', ] -# All test cases in perf_test_names list are non-parallel perf_test_names = [ 'ring_perf_autotest', 'mempool_perf_autotest', @@ -247,7 +241,6 @@ perf_test_names = [ 'stack_lf_perf_autotest', ] -# All test cases in driver_test_names list are non-parallel driver_test_names = [ 'cryptodev_aesni_mb_autotest', 'cryptodev_aesni_gcm_autotest', @@ -269,7 +262,6 @@ driver_test_names = [ 'link_bonding_rssconf_autotest', ] -# All test cases in dump_test_names list are non-parallel dump_test_names = [ 'dump_struct_sizes', 'dump_mempool', @@ -318,7 +310,7 @@ if dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV') test_dep_objs += compress_test_dep test_sources += 'test_compressdev.c' test_deps += 'compressdev' - fast_non_parallel_test_names += 'compressdev_autotest' + fast_test_names += 'compressdev_autotest' endif endif @@ -367,30 +359,23 @@ if get_option('tests') num_cores_arg = '-l ' + num_cores test_args = [num_cores_arg] - foreach arg : fast_parallel_test_names + foreach arg : fast_test_names if host_machine.system() == 'linux' test(arg, dpdk_test, env : ['DPDK_TEST=' + arg], args : test_args + ['--file-prefix=@0@'.format(arg)], timeout : timeout_seconds_fast, + is_parallel : false, suite : 'fast-tests') else test(arg, dpdk_test, env : ['DPDK_TEST=' + arg], args : test_args, timeout : timeout_seconds_fast, - suite : 'fast-tests') - endif - endforeach - - foreach arg : fast_non_parallel_test_names - test(arg, dpdk_test, - env : ['DPDK_TEST=' + arg], - args : test_args, - timeout : timeout_seconds_fast, is_parallel : false, suite : 'fast-tests') + endif endforeach foreach arg : perf_test_names