From patchwork Tue Jun 4 08:59:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 54343 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 236D01BC18; Tue, 4 Jun 2019 11:01:02 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DAC111BB52 for ; Tue, 4 Jun 2019 11:00:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C6DCA3B70; Tue, 4 Jun 2019 09:00:59 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-116-185.ams2.redhat.com [10.36.116.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F33718E32; Tue, 4 Jun 2019 09:00:57 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, aconole@redhat.com, msantana@redhat.com Date: Tue, 4 Jun 2019 10:59:50 +0200 Message-Id: <1559638792-8608-13-git-send-email-david.marchand@redhat.com> In-Reply-To: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 04 Jun 2019 09:00:59 +0000 (UTC) Subject: [dpdk-dev] [PATCH 12/14] test/eal: make the test pass again X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Michael Santana The eal_flags_autotest test currently fails due to a memory leak in the timer library[1][2]. This failure occurs when the test calls one of its subtests test_file_prefix(). Fixing the memory leak is not trivial, so this patch is a workaround that makes the eal_flags_autotest test pass. This is accomplished by moving the test_file_prefix test to its own test unit. This is a temporary measure until the leak is fixed. [1] http://patchwork.dpdk.org/patch/53268/ [2] http://patchwork.dpdk.org/patch/53334/ Signed-off-by: Michael Santana --- app/test/autotest_data.py | 6 ++++++ app/test/meson.build | 1 + app/test/test_eal_flags.c | 7 +------ 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py index 6cf7eca..15e672f 100644 --- a/app/test/autotest_data.py +++ b/app/test/autotest_data.py @@ -93,6 +93,12 @@ "Report": None, }, { + "Name": "EAL flags file prefix autotest", + "Command": "eal_flags_prefix_autotest", + "Func": default_autotest, + "Report": None, + }, + { "Name": "Hash autotest", "Command": "hash_autotest", "Func": default_autotest, diff --git a/app/test/meson.build b/app/test/meson.build index 7ad3684..212cd1b 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -156,6 +156,7 @@ fast_parallel_test_names = [ 'cycles_autotest', 'debug_autotest', 'eal_flags_autotest', + 'eal_flags_prefix_autotest', 'eal_fs_autotest', 'errno_autotest', 'event_ring_autotest', diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index cfa8a61..1e227aa 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -1397,12 +1397,6 @@ enum hugepage_action { return ret; } - ret = test_file_prefix(); - if (ret < 0) { - printf("Error in test_file_prefix()\n"); - return ret; - } - ret = test_misc_flags(); if (ret < 0) { printf("Error in test_misc_flags()"); @@ -1413,3 +1407,4 @@ enum hugepage_action { } REGISTER_TEST_COMMAND(eal_flags_autotest, test_eal_flags); +REGISTER_TEST_COMMAND(eal_flags_prefix_autotest, test_file_prefix);