[18/39] eventdev: add framework for eventmode conf
Checks
Commit Message
Adding eventmode conf which would have all required configuration for
the event mode.
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
---
lib/librte_eventdev/rte_eventmode_helper.c | 16 ++++++++++++++++
lib/librte_eventdev/rte_eventmode_helper_internal.h | 5 +++++
2 files changed, 21 insertions(+)
Comments
> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: Monday, June 3, 2019 11:02 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nikhil Rao
> <nikhil.rao@intel.com>; Erik Gabriel Carrillo <erik.g.carrillo@intel.com>;
> Abhinandan Gujjar <abhinandan.gujjar@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Narayana Prasad Raju Athreya
> <pathreya@marvell.com>; dev@dpdk.org; Lukas Bartosik
> <lbartosik@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; Harry
> van Haaren <harry.van.haaren@intel.com>; Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>; Liang Ma <liang.j.ma@intel.com>
> Subject: [PATCH 18/39] eventdev: add framework for eventmode conf
>
> Adding eventmode conf which would have all required configuration for the
> event mode.
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
> ---
> lib/librte_eventdev/rte_eventmode_helper.c | 16 ++++++++++++++++
> lib/librte_eventdev/rte_eventmode_helper_internal.h | 5 +++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/lib/librte_eventdev/rte_eventmode_helper.c
> b/lib/librte_eventdev/rte_eventmode_helper.c
> index dc2c934..38f1a2b 100644
> --- a/lib/librte_eventdev/rte_eventmode_helper.c
> +++ b/lib/librte_eventdev/rte_eventmode_helper.c
> @@ -97,6 +97,7 @@ rte_eventmode_helper_parse_args(int argc, char
> **argv) {
> int32_t opt, ret;
> struct rte_eventmode_helper_conf *conf = NULL;
> + struct eventmode_conf *em_conf = NULL;
>
> /* Allocate memory for conf */
> conf = rte_zmalloc("eventmode-helper-conf",
> @@ -108,9 +109,21 @@ rte_eventmode_helper_parse_args(int argc, char
> **argv)
> goto err;
> }
>
> + /* Allocate memory for event mode params */
> + conf->mode_params = rte_zmalloc("eventmode-helper-mode-
> params",
Use hugepage alloc memory only fastpath. Malloc() would be fine here.
Hi Jerin,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: Jerin Jacob Kollanukkaran
> Sent: Monday, June 10, 2019 3:36 PM
> To: Anoob Joseph <anoobj@marvell.com>; Nikhil Rao <nikhil.rao@intel.com>;
> Erik Gabriel Carrillo <erik.g.carrillo@intel.com>; Abhinandan Gujjar
> <abhinandan.gujjar@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Narayana Prasad Raju Athreya
> <pathreya@marvell.com>; dev@dpdk.org; Lukas Bartosik
> <lbartosik@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Nipun Gupta <nipun.gupta@nxp.com>; Harry van Haaren
> <harry.van.haaren@intel.com>; Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>; Liang Ma <liang.j.ma@intel.com>
> Subject: RE: [PATCH 18/39] eventdev: add framework for eventmode conf
>
> > -----Original Message-----
> > From: Anoob Joseph <anoobj@marvell.com>
> > Sent: Monday, June 3, 2019 11:02 PM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nikhil Rao
> > <nikhil.rao@intel.com>; Erik Gabriel Carrillo
> > <erik.g.carrillo@intel.com>; Abhinandan Gujjar
> > <abhinandan.gujjar@intel.com>; Bruce Richardson
> > <bruce.richardson@intel.com>; Pablo de Lara
> > <pablo.de.lara.guarch@intel.com>
> > Cc: Anoob Joseph <anoobj@marvell.com>; Narayana Prasad Raju Athreya
> > <pathreya@marvell.com>; dev@dpdk.org; Lukas Bartosik
> > <lbartosik@marvell.com>; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>;
> > Nipun Gupta <nipun.gupta@nxp.com>; Harry van Haaren
> > <harry.van.haaren@intel.com>; Mattias Rönnblom
> > <mattias.ronnblom@ericsson.com>; Liang Ma <liang.j.ma@intel.com>
> > Subject: [PATCH 18/39] eventdev: add framework for eventmode conf
> >
> > Adding eventmode conf which would have all required configuration for
> > the event mode.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
> > ---
> > lib/librte_eventdev/rte_eventmode_helper.c | 16 ++++++++++++++++
> > lib/librte_eventdev/rte_eventmode_helper_internal.h | 5 +++++
> > 2 files changed, 21 insertions(+)
> >
> > diff --git a/lib/librte_eventdev/rte_eventmode_helper.c
> > b/lib/librte_eventdev/rte_eventmode_helper.c
> > index dc2c934..38f1a2b 100644
> > --- a/lib/librte_eventdev/rte_eventmode_helper.c
> > +++ b/lib/librte_eventdev/rte_eventmode_helper.c
> > @@ -97,6 +97,7 @@ rte_eventmode_helper_parse_args(int argc, char
> > **argv) {
> > int32_t opt, ret;
> > struct rte_eventmode_helper_conf *conf = NULL;
> > + struct eventmode_conf *em_conf = NULL;
> >
> > /* Allocate memory for conf */
> > conf = rte_zmalloc("eventmode-helper-conf",
> > @@ -108,9 +109,21 @@ rte_eventmode_helper_parse_args(int argc, char
> > **argv)
> > goto err;
> > }
> >
> > + /* Allocate memory for event mode params */
> > + conf->mode_params = rte_zmalloc("eventmode-helper-mode-
> > params",
>
> Use hugepage alloc memory only fastpath. Malloc() would be fine here.
>
[Anoob] Will fix this in v2.
@@ -97,6 +97,7 @@ rte_eventmode_helper_parse_args(int argc, char **argv)
{
int32_t opt, ret;
struct rte_eventmode_helper_conf *conf = NULL;
+ struct eventmode_conf *em_conf = NULL;
/* Allocate memory for conf */
conf = rte_zmalloc("eventmode-helper-conf",
@@ -108,9 +109,21 @@ rte_eventmode_helper_parse_args(int argc, char **argv)
goto err;
}
+ /* Allocate memory for event mode params */
+ conf->mode_params = rte_zmalloc("eventmode-helper-mode-params",
+ sizeof(struct eventmode_conf),
+ RTE_CACHE_LINE_SIZE);
+ if (conf->mode_params == NULL) {
+ RTE_EM_HLPR_LOG_ERR(
+ "Failed allocating memory for event mode params");
+ goto err;
+ }
+
/* Initialize conf with default values */
em_initialize_helper_conf(conf);
+ em_conf = (struct eventmode_conf *)(conf->mode_params);
+
while ((opt = getopt_long(argc, argv, short_options,
lgopts, NULL)) != EOF) {
switch (opt) {
@@ -131,6 +144,9 @@ rte_eventmode_helper_parse_args(int argc, char **argv)
return conf;
err:
+ if (em_conf != NULL)
+ rte_free(em_conf);
+
if (conf != NULL)
rte_free(conf);
@@ -32,4 +32,9 @@
#define RTE_EM_HLPR_LOG_DEBUG(...) (void)0
#endif
+/* Eventmode conf data */
+struct eventmode_conf {
+ uint64_t dummy;
+};
+
#endif /* _RTE_EVENTMODE_HELPER_INTERNAL_H_ */