net/mlx5: fix sync when handling Tx completions
Checks
Commit Message
Function mlx5_tx_complete() reads completion entry information
from Tx queue.
For some processors not having strongly-ordered memory model,
there has to be a memory barrier between reading the entry index
and the entry fields, in order to guarantee data is valid.
Fixes: 54d3fe948dba ("net/mlx5: poll completion queue once per a call")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.h | 1 +
1 file changed, 1 insertion(+)
Comments
Thursday, February 28, 2019 5:21 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx
> completions
>
> Function mlx5_tx_complete() reads completion entry information from Tx
> queue.
> For some processors not having strongly-ordered memory model, there has
> to be a memory barrier between reading the entry index and the entry
> fields, in order to guarantee data is valid.
>
> Fixes: 54d3fe948dba ("net/mlx5: poll completion queue once per a call")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Applied to next-net-mlx, thanks.
@@ -568,6 +568,7 @@ uint32_t mlx5_tx_update_ext_mp(struct mlx5_txq_data *txq, uintptr_t addr,
}
#endif /* NDEBUG */
++cq_ci;
+ rte_cio_rmb();
txq->wqe_pi = rte_be_to_cpu_16(cqe->wqe_counter);
ctrl = (volatile struct mlx5_wqe_ctrl *)
tx_mlx5_wqe(txq, txq->wqe_pi);