doc/qat: add GCM AAD limitation
Checks
Commit Message
Add limitation that AAD buffer must be padded with zeroes
in GCM case.
Fixes: d4f44265a1d7 ("doc: add limitation of AAD size to QAT guide")
Cc: stable@dpdk.org
Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
doc/guides/cryptodevs/qat.rst | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Thursday, January 17, 2019 7:23 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; akhil.goyal@nxp.com; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>; stable@dpdk.org
> Subject: [PATCH] doc/qat: add GCM AAD limitation
>
> Add limitation that AAD buffer must be padded with zeroes in GCM case.
>
> Fixes: d4f44265a1d7 ("doc: add limitation of AAD size to QAT guide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index 9fb9f01..3ca70bc 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -79,10 +79,9 @@ Limitations
> * SNOW 3G (UIA2) and ZUC (EIA3) supported only if hash length and offset
> fields are byte-multiple.
> * No BSD support as BSD QAT kernel driver not available.
> * ZUC EEA3/EIA3 is not supported by dh895xcc devices
> -* Maximum additional authenticated data (AAD) for GCM is 240 bytes long.
> +* Maximum additional authenticated data (AAD) for GCM is 240 bytes long
> and must be passed to the device in a buffer rounded up to the nearest
> block-size multiple (x16) and padded with zeros.
> * Queue pairs are not thread-safe (that is, within a single queue pair, RX and
> TX from different lcores is not supported).
>
> -
> Extra notes on KASUMI F9
> ~~~~~~~~~~~~~~~~~~~~~~~~
>
> --
> 1.7.0.7
Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > Add limitation that AAD buffer must be padded with zeroes in GCM case.
> >
> > Fixes: d4f44265a1d7 ("doc: add limitation of AAD size to QAT guide")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Applied, thanks
@@ -79,10 +79,9 @@ Limitations
* SNOW 3G (UIA2) and ZUC (EIA3) supported only if hash length and offset fields are byte-multiple.
* No BSD support as BSD QAT kernel driver not available.
* ZUC EEA3/EIA3 is not supported by dh895xcc devices
-* Maximum additional authenticated data (AAD) for GCM is 240 bytes long.
+* Maximum additional authenticated data (AAD) for GCM is 240 bytes long and must be passed to the device in a buffer rounded up to the nearest block-size multiple (x16) and padded with zeros.
* Queue pairs are not thread-safe (that is, within a single queue pair, RX and TX from different lcores is not supported).
-
Extra notes on KASUMI F9
~~~~~~~~~~~~~~~~~~~~~~~~