diff mbox series

test/crypto: don't attempt unsupported SGL tests on aesni mb PMD

Message ID 1545350539-7065-1-git-send-email-fiona.trahe@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series test/crypto: don't attempt unsupported SGL tests on aesni mb PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Fiona Trahe Dec. 21, 2018, 12:02 a.m. UTC 
Remove AESNI_MB flag from SGL test cases which it doesn't support.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 test/test/test_cryptodev_aes_test_vectors.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

De Lara Guarch, Pablo Dec. 21, 2018, 11:52 a.m. UTC | #1 
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:02 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com
> Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> mb PMD
> 
> Remove AESNI_MB flag from SGL test cases which it doesn't support.
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>

Patch looks good, but I wonder if this is a fix and therefore, if it needs to be backported.

Thanks,
Pablo
Fiona Trahe Dec. 21, 2018, 5:44 p.m. UTC | #2 
Hi Pablo,

Thanks for reviewing

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, December 21, 2018 4:52 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com
> Subject: RE: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni mb PMD
> 
> 
> 
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:02 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> > <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> > akhil.goyal@nxp.com
> > Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> > mb PMD
> >
> > Remove AESNI_MB flag from SGL test cases which it doesn't support.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> Patch looks good, but I wonder if this is a fix and therefore, if it needs to be backported.
[Fiona] It did previously print a message saying the device doesn't support
 the test case, so I think more of a style change than a bug. I think this way is clearer but
not necessary to backport cause only really of interest to developers and
dev of new test cases are usually done on latest.

> 
> Thanks,
> Pablo
De Lara Guarch, Pablo Jan. 11, 2019, 11:04 a.m. UTC | #3 
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:02 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com
> Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on aesni
> mb PMD
> 
> Remove AESNI_MB flag from SGL test cases which it doesn't support.
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo Jan. 11, 2019, 11:13 a.m. UTC | #4 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Friday, January 11, 2019 11:05 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com
> Subject: Re: [dpdk-dev] [PATCH] test/crypto: don't attempt unsupported SGL
> tests on aesni mb PMD
> 
> 
> 
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:02 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe,
> > Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan
> > <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com
> > Subject: [PATCH] test/crypto: don't attempt unsupported SGL tests on
> > aesni mb PMD
> >
> > Remove AESNI_MB flag from SGL test cases which it doesn't support.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.

Thanks,
Pablo
diff mbox series

Patch

diff --git a/test/test/test_cryptodev_aes_test_vectors.h b/test/test/test_cryptodev_aes_test_vectors.h
index fff28bc9b..6dd8e5f96 100644
--- a/test/test/test_cryptodev_aes_test_vectors.h
+++ b/test/test/test_cryptodev_aes_test_vectors.h
@@ -1213,7 +1213,7 @@  static const struct blockcipher_test_case aes_chain_test_cases[] = {
 		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
 			BLOCKCIPHER_TEST_FEATURE_OOP,
-		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+		.pmd_mask =
 			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
 			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER
 	},
@@ -1278,7 +1278,7 @@  static const struct blockcipher_test_case aes_chain_test_cases[] = {
 		.op_mask = BLOCKCIPHER_TEST_OP_ENC_AUTH_GEN,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
 			BLOCKCIPHER_TEST_FEATURE_OOP,
-		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+		.pmd_mask =
 			BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
 			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
 			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
@@ -1408,7 +1408,7 @@  static const struct blockcipher_test_case aes_chain_test_cases[] = {
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_SESSIONLESS |
 			BLOCKCIPHER_TEST_FEATURE_SG |
 			BLOCKCIPHER_TEST_FEATURE_OOP,
-		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+		.pmd_mask =
 			BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
 			BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX
 	},
@@ -1435,7 +1435,7 @@  static const struct blockcipher_test_case aes_chain_test_cases[] = {
 		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY_DEC,
 		.feature_mask = BLOCKCIPHER_TEST_FEATURE_SG |
 			BLOCKCIPHER_TEST_FEATURE_OOP,
-		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |
+		.pmd_mask =
 			BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
 			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
 			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |