diff mbox series

test/crypto: fix misleading trace message

Message ID 1545350485-6025-1-git-send-email-fiona.trahe@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series test/crypto: fix misleading trace message |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Fiona Trahe Dec. 21, 2018, 12:01 a.m. UTC 
Test was reporting digest verification failed for all operation errors.
Fixed so it only reports this if the PMD actually reports an auth failure.

Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
CC: stable@dpdk.org

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 test/test/test_cryptodev_blockcipher.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

De Lara Guarch, Pablo Dec. 21, 2018, 11:41 a.m. UTC | #1 
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:01 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com; stable@dpdk.org
> Subject: [PATCH] test/crypto: fix misleading trace message
> 
> Test was reporting digest verification failed for all operation errors.
> Fixed so it only reports this if the PMD actually reports an auth failure.
> 
> Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
> CC: stable@dpdk.org
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo Jan. 9, 2019, 10:45 p.m. UTC | #2 
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of De Lara
> Guarch, Pablo
> Sent: Friday, December 21, 2018 11:42 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com;
> stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] test/crypto: fix misleading trace message
> 
> 
> 
> > -----Original Message-----
> > From: Trahe, Fiona
> > Sent: Friday, December 21, 2018 12:01 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe,
> > Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan
> > <roy.fan.zhang@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
> > Subject: [PATCH] test/crypto: fix misleading trace message
> >
> > Test was reporting digest verification failed for all operation errors.
> > Fixed so it only reports this if the PMD actually reports an auth failure.
> >
> > Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.

Thanks,
Pablo
De Lara Guarch, Pablo Jan. 11, 2019, 12:05 a.m. UTC | #3 
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, December 21, 2018 12:01 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> akhil.goyal@nxp.com; stable@dpdk.org
> Subject: [PATCH] test/crypto: fix misleading trace message
> 
> Test was reporting digest verification failed for all operation errors.
> Fixed so it only reports this if the PMD actually reports an auth failure.
> 
> Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
> CC: stable@dpdk.org
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.

Thanks,
Pablo
diff mbox series

Patch

diff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c
index 1c3f29f6b..4f1298ea2 100644
--- a/test/test/test_cryptodev_blockcipher.c
+++ b/test/test/test_cryptodev_blockcipher.c
@@ -401,13 +401,14 @@  test_blockcipher_one_case(const struct blockcipher_test_case *t,
 
 	/* Verify results */
 	if (op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {
-		if (t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY)
+		if ((t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY) &&
+			(op->status == RTE_CRYPTO_OP_STATUS_AUTH_FAILED))
 			snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u "
 				"FAILED: Digest verification failed "
 				"(0x%X)", __LINE__, op->status);
 		else
 			snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u "
-				"FAILED: Digest verification failed "
+				"FAILED: Operation failed "
 				"(0x%X)", __LINE__, op->status);
 		status = TEST_FAILED;
 		goto error_exit;