diff mbox series

[v2,20/20] net/ice: support meson build

Message ID 1543820821-108122-21-git-send-email-wenzhuo.lu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers show
Series A new net PMD - ice | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Wenzhuo Lu Dec. 3, 2018, 7:07 a.m. UTC
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/ice/base/meson.build | 30 ++++++++++++++++++++++++++++++
 drivers/net/ice/meson.build      | 15 +++++++++++++++
 drivers/net/meson.build          |  1 +
 3 files changed, 46 insertions(+)
 create mode 100644 drivers/net/ice/base/meson.build
 create mode 100644 drivers/net/ice/meson.build

Comments

Varghese, Vipin Dec. 3, 2018, 10 a.m. UTC | #1
Should not meson build option be add start. That is in patch 1/20 so compile options does not fail?

Thanks
Vipin Varghese
Wenzhuo Lu Dec. 5, 2018, 7:03 a.m. UTC | #2
Hi Vipin,


> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, December 3, 2018 6:01 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
> 
> Should not meson build option be add start. That is in patch 1/20 so compile
> options does not fail?
It will not fail. Enabling the compile earlier only means the code can be compiled. But, to use this device we do need the whole patch set. From this point of view, compiling it at the end maybe better.

> 
> Thanks
> Vipin Varghese
Varghese, Vipin Dec. 6, 2018, 4:31 a.m. UTC | #3
Hi Wenzhuo

snipped
> >
> > Should not meson build option be add start. That is in patch 1/20 so
> > compile options does not fail?
> It will not fail. Enabling the compile earlier only means the code can be compiled.
> But, to use this device we do need the whole patch set. From this point of view,
> compiling it at the end maybe better.
Thanks for update, so will 'meson-build' success if apply 3 patches?

> 
> >
> > Thanks
> > Vipin Varghese
Wenzhuo Lu Dec. 6, 2018, 5:59 a.m. UTC | #4
Hi Vipin,


> -----Original Message-----
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 12:31 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
> 
> Hi Wenzhuo
> 
> snipped
> > >
> > > Should not meson build option be add start. That is in patch 1/20 so
> > > compile options does not fail?
> > It will not fail. Enabling the compile earlier only means the code can be
> compiled.
> > But, to use this device we do need the whole patch set. From this
> > point of view, compiling it at the end maybe better.
> Thanks for update, so will 'meson-build' success if apply 3 patches?
Sure, meson build will not be broken by any one of these patches. Only until this patch, what built by meson can support ice.

> 
> >
> > >
> > > Thanks
> > > Vipin Varghese
Varghese, Vipin Dec. 6, 2018, 6:05 a.m. UTC | #5
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Thursday, December 6, 2018 11:29 AM
> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
> 
> Hi Vipin,
> 
> 
> > -----Original Message-----
> > From: Varghese, Vipin
> > Sent: Thursday, December 6, 2018 12:31 PM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> > Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
> >
> > Hi Wenzhuo
> >
> > snipped
> > > >
> > > > Should not meson build option be add start. That is in patch 1/20
> > > > so compile options does not fail?
> > > It will not fail. Enabling the compile earlier only means the code
> > > can be
> > compiled.
> > > But, to use this device we do need the whole patch set. From this
> > > point of view, compiling it at the end maybe better.
> > Thanks for update, so will 'meson-build' success if apply 3 patches?
> Sure, meson build will not be broken by any one of these patches. Only until this
> patch, what built by meson can support ice.
Thanks for confirmation that you have tried './devtools/test-meson-builds.sh' and the intermediate build for ICE_DSI PMD does not fail.

> 
> >
> > >
> > > >
> > > > Thanks
> > > > Vipin Varghese
diff mbox series

Patch

diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
new file mode 100644
index 0000000..5aafff3
--- /dev/null
+++ b/drivers/net/ice/base/meson.build
@@ -0,0 +1,30 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+sources = [
+	'ice_controlq.c',
+	'ice_common.c',
+	'ice_sched.c',
+	'ice_switch.c',
+	'ice_nvm.c',
+]
+
+error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
+		'-Wno-format', '-Wno-error=format-security',
+		'-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
+		'-Wno-unused-variable',
+]
+c_args = cflags
+if allow_experimental_apis
+	c_args += '-DALLOW_EXPERIMENTAL_API'
+endif
+foreach flag: error_cflags
+	if cc.has_argument(flag)
+		c_args += flag
+	endif
+endforeach
+
+base_lib = static_library('ice_base', sources,
+	dependencies: static_rte_eal,
+	c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build
new file mode 100644
index 0000000..b921354
--- /dev/null
+++ b/drivers/net/ice/meson.build
@@ -0,0 +1,15 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Intel Corporation
+
+cflags += ['-DALLOW_EXPERIMENTAL_API']
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+	'ice_ethdev.c',
+	'ice_lan_rxtx.c'
+	)
+
+deps += ['hash']
+includes += include_directories('base')
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 980eec2..45da3bb 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -17,6 +17,7 @@  drivers = ['af_packet',
 	'enic',
 	'failsafe',
 	'fm10k', 'i40e',
+	'ice',
 	'ifc',
 	'ixgbe',
 	'kni',