diff mbox series

[v2,2/2] devtools: drop '+' from the section name

Message ID 1543581122-22501-2-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series [v2,1/2] devtools: report the incorrect section when complaining | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

David Marchand Nov. 30, 2018, 12:32 p.m. UTC
The incriminated commit did relax the condition to catch all sections
but dropped the + removal which can triggers false detection of the
special EXPERIMENTAL section when adding symbols and the section in the
same patch.

Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 devtools/check-symbol-change.sh | 1 +
 1 file changed, 1 insertion(+)

Comments

Neil Horman Nov. 30, 2018, 3:28 p.m. UTC | #1
On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote:
> The incriminated commit did relax the condition to catch all sections
> but dropped the + removal which can triggers false detection of the
> special EXPERIMENTAL section when adding symbols and the section in the
> same patch.
> 
> Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  devtools/check-symbol-change.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index 4b8d9f3..020da7e 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -31,6 +31,7 @@ build_map_changes()
>  		# Triggering this rule sets in_sec to 1, which actives the
>  		# symbol rule below
>  		/^.*{/ {
> +			gsub("+", "");
>  			if (in_map == 1) {
>  				sec=$(NF-1); in_sec=1;
>  			}
> -- 
> 1.8.3.1
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

Thanks!
Neil
David Marchand Nov. 30, 2018, 3:43 p.m. UTC | #2
Thomas,

On Fri, Nov 30, 2018 at 4:28 PM Neil Horman <nhorman@tuxdriver.com> wrote:

> On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote:
> > The incriminated commit did relax the condition to catch all sections
> > but dropped the + removal which can triggers false detection of the
> > special EXPERIMENTAL section when adding symbols and the section in the
> > same patch.
> >
> > Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol
> section")
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>

Can you take the two little patches from this patchset ?
I am pretty sure people will hit this issue with all these new apis coming
:-).

Thanks.
Ferruh Yigit Nov. 30, 2018, 5:17 p.m. UTC | #3
On 11/30/2018 3:28 PM, Neil Horman wrote:
> On Fri, Nov 30, 2018 at 01:32:02PM +0100, David Marchand wrote:
>> The incriminated commit did relax the condition to catch all sections
>> but dropped the + removal which can triggers false detection of the
>> special EXPERIMENTAL section when adding symbols and the section in the
>> same patch.
>>
>> Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Series applied, thanks.
diff mbox series

Patch

diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 4b8d9f3..020da7e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -31,6 +31,7 @@  build_map_changes()
 		# Triggering this rule sets in_sec to 1, which actives the
 		# symbol rule below
 		/^.*{/ {
+			gsub("+", "");
 			if (in_map == 1) {
 				sec=$(NF-1); in_sec=1;
 			}