From patchwork Wed Nov 28 13:55:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 48388 X-Patchwork-Delegate: cristian.dumitrescu@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D1701B497; Wed, 28 Nov 2018 14:56:10 +0100 (CET) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id D4F6C1B450 for ; Wed, 28 Nov 2018 14:56:06 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id 17so9546940pgg.1 for ; Wed, 28 Nov 2018 05:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=t77QJyqkZ51vMpHxkmlVRqqiOFglxzEvj2nvyJU1Yls=; b=Wy86ckK+QfXDYsFtZskO2kQZC542ojdOnwFZSSfxGZlUl2IJEzzSmgTT/pKFvBlvFP s/+7YbrTxkAqJEC8BoWJSecuJ20MWuQtsVyw/tJMDmoVEJB6tsmy2MjcOOF8DGJU6ZCm 6U3d5e9kbX1lSgWK3N9prrR79w/YTvg1uiV71TOHMPbKvhdD/3IHWl2RhYAWgaKY4OtM onmTqs0z3/FbOrcVV2FKdSUQAb2dWfdx7EqiMXmc7tiR0tWsI4qzwUi4Wm9OxXYPnA8b 9+slf9ezm1D54HRvCopa9ezn1xAmA0gvaLfuBzaa0tlveg5VsqsS3BKr+QwNTeJTGqO/ y2Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=t77QJyqkZ51vMpHxkmlVRqqiOFglxzEvj2nvyJU1Yls=; b=PV/78XuDmd/+ndwdOR70CtitvXuUhL8CT0gAaCCIEP8pF9gHm6gxGaqIJaCJXTzZmC VumRTsI3Hk7t3YWihH0mRtV9L9i6qdzy+56nsNeXyl+VM2yNvZGzjLIaINqtgkq2O8tv WcV8q3K4v/de/HrStqDdYwsi/RkbfU+ptYWOH29jbsV1cJ5vDvoFsNvlgDh+98ZilbE6 biieTfwIh2eCO32LLJ5lxJfMYFcf5BUpI3dg6qcVkPR+qhAaK2cmER5gpsj3E6QBtZ/g Bc2puXBsuOvSO9DwDT+ap1nviRGZJldJTwHzPLwR8xB8onS2WEiTyuyXSSCjx61hZdSH WsRQ== X-Gm-Message-State: AA+aEWaS0PVjUAHcIqk0rPhPNC6jvCvBBNblG5IZUa8k1d/Yl+0QzZtA VVS8xYuXKToKC5OX+g9TKR8plMvo X-Google-Smtp-Source: AFSGD/XcAIyXH7AK3609Fks5Kysi8PVuSCOqXEjnBcksSPE3IT4IX2crJpAGAVjDQuC89/CYaa+AFA== X-Received: by 2002:aa7:80d7:: with SMTP id a23mr250460pfn.86.1543413366013; Wed, 28 Nov 2018 05:56:06 -0800 (PST) Received: from local.opencloud.tech.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id e86sm9876872pfb.6.2018.11.28.05.56.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 05:56:05 -0800 (PST) From: Tonghao Zhang To: dev@dpdk.org Cc: Tonghao Zhang Date: Wed, 28 Nov 2018 05:55:55 -0800 Message-Id: <1543413355-2874-2-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1543413355-2874-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1543413355-2874-1-git-send-email-xiangxia.m.yue@gmail.com> Subject: [dpdk-dev] [PATCH 2/2] sched: fix possible mem leak on initialize X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In some case, we may create sched port dynamically, if err when creating so memory will leak. Signed-off-by: Tonghao Zhang Acked-by: Cristian Dumitrescu --- lib/librte_sched/rte_sched.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 17de6e6..a3adcca 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -724,6 +724,7 @@ struct rte_sched_port * bmp_mem_size); if (port->bmp == NULL) { RTE_LOG(ERR, SCHED, "Bitmap init error\n"); + rte_free(port); return NULL; }