[1/2] net/qede: fix Tx offload mask

Message ID 1542835225-26407-1-git-send-email-rasesh.mody@cavium.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/2] net/qede: fix Tx offload mask |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Mody, Rasesh Nov. 21, 2018, 9:20 p.m. UTC
  From: Shahed Shaikh <shahed.shaikh@cavium.com>

Following commit updated the Tx offload mask
commit 1037ed842c37 ("mbuf: fix Tx offload mask").

So, not having PKT_TX_IPV6 and PKT_TX_IPV4 in qede PMDs supported
Tx offload mask breaks TSO support since application will fail in transmit
prepare function.

Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask")
Cc: stable@dpdk.org

Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
---
 drivers/net/qede/qede_rxtx.h |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Comments

Ferruh Yigit Nov. 22, 2018, 10:05 a.m. UTC | #1
On 11/21/2018 9:20 PM, Mody, Rasesh wrote:
> From: Shahed Shaikh <shahed.shaikh@cavium.com>
> 
> Following commit updated the Tx offload mask
> commit 1037ed842c37 ("mbuf: fix Tx offload mask").
> 
> So, not having PKT_TX_IPV6 and PKT_TX_IPV4 in qede PMDs supported
> Tx offload mask breaks TSO support since application will fail in transmit
> prepare function.
> 
> Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>

Series applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/qede/qede_rxtx.h b/drivers/net/qede/qede_rxtx.h
index 0afadd8..454daa0 100644
--- a/drivers/net/qede/qede_rxtx.h
+++ b/drivers/net/qede/qede_rxtx.h
@@ -149,7 +149,9 @@ 
 				   PKT_TX_TCP_CKSUM             | \
 				   PKT_TX_UDP_CKSUM             | \
 				   PKT_TX_OUTER_IP_CKSUM        | \
-				   PKT_TX_TCP_SEG)
+				   PKT_TX_TCP_SEG		| \
+				   PKT_TX_IPV4			| \
+				   PKT_TX_IPV6)
 
 #define QEDE_TX_OFFLOAD_MASK (QEDE_TX_CSUM_OFFLOAD_MASK | \
 			      PKT_TX_VLAN_PKT		| \