diff mbox series

net/mlx5: fix flow director add and delete

Message ID 1541712585-5768-1-git-send-email-dekelp@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Shahaf Shuler
Headers
Series net/mlx5: fix flow director add and delete |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Dekel Peled Nov. 8, 2018, 9:29 p.m. UTC 
  Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
This function is used by flow_fdir_filter_add() to check if same rule
exists, and by flow_fdir_filter_delete() to find flow rule to delete.

The function compared actions conf pointers, changed to compare
actions type only.

Fixes: 2720f833d461 ("net/mlx5: add missing flow director delete")
Cc: yskoh@mellanox.com

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yongseok Koh Nov. 8, 2018, 10:12 p.m. UTC | #1 
> On Nov 8, 2018, at 1:29 PM, Dekel Peled <dekelp@mellanox.com> wrote:
> 
> Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
> This function is used by flow_fdir_filter_add() to check if same rule
> exists, and by flow_fdir_filter_delete() to find flow rule to delete.
> 
> The function compared actions conf pointers, changed to compare
> actions type only.
> 
> Fixes: 2720f833d461 ("net/mlx5: add missing flow director delete")
> Cc: yskoh@mellanox.com
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---

Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks
Shahaf Shuler Nov. 11, 2018, 12:41 p.m. UTC | #2 
Friday, November 9, 2018 12:12 AM¸ Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix flow director add and delete
> 
> 
> > On Nov 8, 2018, at 1:29 PM, Dekel Peled <dekelp@mellanox.com> wrote:
> >
> > Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
> > This function is used by flow_fdir_filter_add() to check if same rule
> > exists, and by flow_fdir_filter_delete() to find flow rule to delete.
> >
> > The function compared actions conf pointers, changed to compare
> > actions type only.
> >
> > Fixes: 2720f833d461 ("net/mlx5: add missing flow director delete")
> > Cc: yskoh@mellanox.com
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > ---
> 
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

> 
> Thanks
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8039664..21d65f4 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2663,7 +2663,7 @@  struct rte_flow *
 	    FLOW_FDIR_CMP(f1, f2, l3_mask) ||
 	    FLOW_FDIR_CMP(f1, f2, l4) ||
 	    FLOW_FDIR_CMP(f1, f2, l4_mask) ||
-	    FLOW_FDIR_CMP(f1, f2, actions[0]))
+	    FLOW_FDIR_CMP(f1, f2, actions[0].type))
 		return 1;
 	if (f1->actions[0].type == RTE_FLOW_ACTION_TYPE_QUEUE &&
 	    FLOW_FDIR_CMP(f1, f2, queue))