diff mbox series

examples/flow_filtering: fix capability setting

Message ID 1541485898-25572-1-git-send-email-orika@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series examples/flow_filtering: fix capability setting | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

Ori Kam Nov. 6, 2018, 6:32 a.m. UTC
The tx offloads should be compared to tx capability

Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap")
Cc: orika@mellanox.com
Cc: wei.zhao1@intel.com

Signed-off-by: Ori Kam <orika@mellanox.com>
---
 examples/flow_filtering/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhao1, Wei Nov. 7, 2018, 2:43 a.m. UTC | #1
Acked-by: Wei Zhao <wei.zhao1@intel.com>


> -----Original Message-----
> From: Ori Kam [mailto:orika@mellanox.com]
> Sent: Tuesday, November 6, 2018 2:32 PM
> To: Ori Kam <orika@mellanox.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] examples/flow_filtering: fix capability setting
> 
> The tx offloads should be compared to tx capability
> 
> Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap")
> Cc: orika@mellanox.com
> Cc: wei.zhao1@intel.com
> 
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
>  examples/flow_filtering/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
> index 27e287a..a582ac0 100644
> --- a/examples/flow_filtering/main.c
> +++ b/examples/flow_filtering/main.c
> @@ -137,7 +137,7 @@
>  	struct rte_eth_dev_info dev_info;
> 
>  	rte_eth_dev_info_get(port_id, &dev_info);
> -	port_conf.txmode.offloads &= dev_info.rx_offload_capa;
> +	port_conf.txmode.offloads &= dev_info.tx_offload_capa;
>  	printf(":: initializing port: %d\n", port_id);
>  	ret = rte_eth_dev_configure(port_id,
>  				nr_queues, nr_queues, &port_conf);
> --
> 1.8.3.1
Ferruh Yigit Nov. 7, 2018, 6:17 p.m. UTC | #2
On 11/7/2018 2:43 AM, Zhao1, Wei wrote:

> 
>> -----Original Message-----
>> From: Ori Kam [mailto:orika@mellanox.com]
>> Sent: Tuesday, November 6, 2018 2:32 PM
>> To: Ori Kam <orika@mellanox.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Cc: dev@dpdk.org
>> Subject: [PATCH] examples/flow_filtering: fix capability setting
>>
>> The tx offloads should be compared to tx capability
>>
>> Fixes: fb152e54ee04 ("examples/flow_filtering: fix set offloads based oncap")
>> Cc: orika@mellanox.com
>> Cc: wei.zhao1@intel.com
>>
>> Signed-off-by: Ori Kam <orika@mellanox.com>
>
> Acked-by: Wei Zhao <wei.zhao1@intel.com>

Fixes: c82f2f8b4b3a ("examples/flow_filtering: filter out unsupported offloads")
Cc: stable@dpdk.org

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index 27e287a..a582ac0 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -137,7 +137,7 @@ 
 	struct rte_eth_dev_info dev_info;
 
 	rte_eth_dev_info_get(port_id, &dev_info);
-	port_conf.txmode.offloads &= dev_info.rx_offload_capa;
+	port_conf.txmode.offloads &= dev_info.tx_offload_capa;
 	printf(":: initializing port: %d\n", port_id);
 	ret = rte_eth_dev_configure(port_id,
 				nr_queues, nr_queues, &port_conf);