[v2,3/6] bus/pci: check iommu addressing limitation just once
Checks
Commit Message
Current code checks if IOMMU hardware reports enough addressing
bits for using IOVA mode but it repeats the same check for any
PCI device present. This is not necessary because the IOMMU hardware
is the same for all of them.
This patch only checks the IOMMU using first PCI device found.
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/bus/pci/linux/pci.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Comments
On 05-Oct-18 1:06 PM, Alejandro Lucero wrote:
> Current code checks if IOMMU hardware reports enough addressing
> bits for using IOVA mode but it repeats the same check for any
> PCI device present. This is not necessary because the IOMMU hardware
> is the same for all of them.
>
> This patch only checks the IOMMU using first PCI device found.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
@@ -620,8 +620,11 @@
FOREACH_DEVICE_ON_PCIBUS(dev) {
if (!rte_pci_match(drv, dev))
continue;
- if (!pci_one_device_iommu_support_va(dev))
- return false;
+ /*
+ * just one PCI device needs to be checked out because
+ * the IOMMU hardware is the same for all of them.
+ */
+ return pci_one_device_iommu_support_va(dev);
}
}
return true;