diff mbox series

[6/6] net/vdev_netvsc: disable vdev netvsc build in FREEBSD

Message ID 1538054652-20820-7-git-send-email-agalyax.babu.radhakrishnan@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series fix for meson builds in freebsd |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Babu Radhakrishnan, AgalyaX Sept. 27, 2018, 1:24 p.m. UTC 
  Disabled vdev_netvsc build in FreeBSD because it is not supported
Added changes to enable vdev_netvsc build if it is Linux OS and
disable in FreeBSD.

Fixes: 6e8a721044 ("vfio: export functions even when disabled")

Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
---
 drivers/net/vdev_netvsc/meson.build | 3 +++
 1 file changed, 3 insertions(+)

Comments

Luca Boccassi Sept. 27, 2018, 1:42 p.m. UTC | #1 
On Thu, 2018-09-27 at 14:24 +0100, Agalya Babu RadhaKrishnan wrote:
> Disabled vdev_netvsc build in FreeBSD because it is not supported
> Added changes to enable vdev_netvsc build if it is Linux OS and
> disable in FreeBSD.
> 
> Fixes: 6e8a721044 ("vfio: export functions even when disabled")
> 
> Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@
> intel.com>
> ---

Hi,

I don't think these "Fixes" lines in this set are correct - for
example, the vdev_netvsc pmd only got the Meson file recently, but the
mentioned commit was back in 18.05. This would cause this individual
patch to be picked for the 18.08.1 stable release, even though it
shouldn't as the Meson file would be new in 18.11. Same might be true
for the other patches.
diff mbox series

Patch

diff --git a/drivers/net/vdev_netvsc/meson.build b/drivers/net/vdev_netvsc/meson.build
index cc956e7b2..d3ada878a 100644
--- a/drivers/net/vdev_netvsc/meson.build
+++ b/drivers/net/vdev_netvsc/meson.build
@@ -1,6 +1,9 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
 
+if host_machine.system() != 'linux'
+        build = false
+endif
 sources = files('vdev_netvsc.c')
 
 allow_experimental_apis = true