[5/6] net/tap: disable tap build in FREEBSD

Message ID 1538054652-20820-6-git-send-email-agalyax.babu.radhakrishnan@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series fix for meson builds in freebsd |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Babu Radhakrishnan, AgalyaX Sept. 27, 2018, 1:24 p.m. UTC
  Disabled tap build in FreeBSD because it is not supported
Added changes to enable tap build if it is Linux OS and
disable in FreeBSD.

Fixes: 6e8a721044 ("vfio: export functions even when disabled")

Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
---
 drivers/net/tap/meson.build | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Wiles, Keith Sept. 27, 2018, 1:45 p.m. UTC | #1
> On Sep 27, 2018, at 8:24 AM, Babu Radhakrishnan, AgalyaX <agalyax.babu.radhakrishnan@intel.com> wrote:
> 
> Disabled tap build in FreeBSD because it is not supported
> Added changes to enable tap build if it is Linux OS and
> disable in FreeBSD.

Good, the old build system restricted tap to Linux only.

Acked-by: Keith Wiles <keith.wiles@intel.com>
> 
> Fixes: 6e8a721044 ("vfio: export functions even when disabled")
> 
> Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> ---
> drivers/net/tap/meson.build | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
> index 37f65b75c..5d30cd52d 100644
> --- a/drivers/net/tap/meson.build
> +++ b/drivers/net/tap/meson.build
> @@ -1,6 +1,9 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright 2018 Luca Boccassi <bluca@debian.org>
> 
> +if host_machine.system() != 'linux'
> +        build = false
> +endif
> sources = files(
> 	'rte_eth_tap.c',
> 	'tap_bpf_api.c',
> -- 
> 2.13.6
> 

Regards,
Keith
  

Patch

diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
index 37f65b75c..5d30cd52d 100644
--- a/drivers/net/tap/meson.build
+++ b/drivers/net/tap/meson.build
@@ -1,6 +1,9 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2018 Luca Boccassi <bluca@debian.org>
 
+if host_machine.system() != 'linux'
+        build = false
+endif
 sources = files(
 	'rte_eth_tap.c',
 	'tap_bpf_api.c',