diff mbox series

[1/2] compress/qat: fix for zero checksum on decompression

Message ID 1537622738-29475-1-git-send-email-fiona.trahe@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [1/2] compress/qat: fix for zero checksum on decompression |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Fiona Trahe Sept. 22, 2018, 1:25 p.m. UTC 
Checksum was always 0 on QAT decompression due to
incorrect use of union variable.

Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
Cc: stable@dpdk.org

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 drivers/compress/qat/qat_comp.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Tomasz Jozwiak Sept. 27, 2018, 11:25 a.m. UTC | #1 
> -----Original Message-----
> From: Fiona Trahe <fiona.trahe@intel.com>
> Date:  Sat, 22 Sep 2018 14:25:37 +0100
> Subject: [dpdk-dev] [PATCH 1/2] compress/qat: fix for zero checksum on
> decompression
> To: dev@dpdk.org
> CC: akhil.goyal@nxp.com, stable@dpdk.org, Fiona Trahe
> <fiona.trahe@intel.com>
> 
> Checksum was always 0 on QAT decompression due to incorrect use of union
> variable.
> 
> Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---

Acked-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Akhil Goyal Sept. 27, 2018, 11:47 a.m. UTC | #2 
On 9/22/2018 6:55 PM, Fiona Trahe wrote:
> Checksum was always 0 on QAT decompression due to
> incorrect use of union variable.
>
> Fixes: 6a7ea14819e9 ("compress/qat: add xform processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
>
Applied to dpdk-next-crypto

Thanks
diff mbox series

Patch

diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index 38c8a5b..6f1f2dc 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -345,17 +345,16 @@  qat_comp_private_xform_create(struct rte_compressdev *dev,
 		if (xform->compress.deflate.huffman == RTE_COMP_HUFFMAN_FIXED ||
 		  ((xform->compress.deflate.huffman == RTE_COMP_HUFFMAN_DEFAULT)
 				   && qat->interm_buff_mz == NULL))
-
 			qat_xform->qat_comp_request_type =
 					QAT_COMP_REQUEST_FIXED_COMP_STATELESS;
 
+		qat_xform->checksum_type = xform->compress.chksum;
 
 	} else {
 		qat_xform->qat_comp_request_type = QAT_COMP_REQUEST_DECOMPRESS;
+		qat_xform->checksum_type = xform->decompress.chksum;
 	}
 
-	qat_xform->checksum_type = xform->compress.chksum;
-
 	if (qat_comp_create_templates(qat_xform, qat->interm_buff_mz, xform)) {
 		QAT_LOG(ERR, "QAT: Problem with setting compression");
 		return -EINVAL;