Message ID | 1536299726-20927-1-git-send-email-anoob.joseph@caviumnetworks.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | akhil goyal |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F3493772; Fri, 7 Sep 2018 07:56:42 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0079.outbound.protection.outlook.com [104.47.37.79]) by dpdk.org (Postfix) with ESMTP id BB18E325F for <dev@dpdk.org>; Fri, 7 Sep 2018 07:56:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M9Vh8f3yiUTfUfwfTJEIWP3KxLUqtyN6To75jPY1nDM=; b=Ci7daYboqM5U3wVnL8YpE0I6Me61cc1ys2QTngw/wkoUeSi33v8dsCjE9sZkA536EQXSPNw2Jlj5WEtUm0cyTRKgM0G0OwvquAsdZYC6PglRc3sV0SHdGv9FEFlYC4/pQNP6rhI16U019RJt84uQtLTLUV0JzzqcKq+Ozcb8/K4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from ajoseph83.caveonetworks.com.com (115.113.156.2) by BN7PR07MB4900.namprd07.prod.outlook.com (2603:10b6:408::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Fri, 7 Sep 2018 05:56:32 +0000 From: Anoob Joseph <anoob.joseph@caviumnetworks.com> To: Akhil Goyal <akhil.goyal@nxp.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Radu Nicolau <radu.nicolau@intel.com> Cc: Anoob Joseph <anoob.joseph@caviumnetworks.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>, Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org, Archana Muniganti <muniganti.archana@caviumnetworks.com> Date: Fri, 7 Sep 2018 11:25:26 +0530 Message-Id: <1536299726-20927-1-git-send-email-anoob.joseph@caviumnetworks.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: MAXPR0101CA0024.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::34) To BN7PR07MB4900.namprd07.prod.outlook.com (2603:10b6:408::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0765fd3-e478-4ff0-c7ea-08d61486ab62 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BN7PR07MB4900; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 3:UB6x9q1xDlzCirLmvbd3cZ3ou/Qa+mj3OFvceEOqSZ22TaMxlekstvNGGHxISj/qZoDSpF0B5rr6aQDXvqtFCGKResnV/EaAUbDXDDI4m/1byjWt+VGoHAQiMo2hHZUHmm69SiWf5WWncxzvz53MISX5q/POD6qOs5ZLR1N1cNMlE8651l0grE4XExUw0lFNgXcBtlPPw6x3TwE4LkH9keQU7fHk2TitIHBxtptgn2cP6Tz3r2S83GleCClYcgel; 25:hCUgC7lQkDJ4cVGxIdX2KGMWAy5RE8O1yZ208Ub/7GH+ImGvPvIMOJeDZeYc5UvcdvcliFRMdVqtsULkSKaGdGfUvePEOMb1GpZ2RmGCly99qSSr4VRc+fJxznlU9mgzZvfLkJIe8aTa+n9CYEkn6bDvN+A2PnavngvGKec+Yhf+gnCYbEi3LDbedg/KCRY+SyOY5cJ4p/ZMOGBlqCeEzELMhCJWO0WaYgWVeGcSwsZMY3fzJxZB59CSiFsTEpqTq9NcvkMuvbepUZO7gvqjhDfCVZCk7GEKdw1x8fesGbj013R0c7Q6VmA3K0UqcNB4suhkiiCnmT/lM8qRXm3Mkg==; 31:SEMMZj/SJW56jK4VMb4YQd87s8dmhcBqbotFJHYJJTh+i0TChQwTSktRgmt1lQQu7h5zmNhmFiJ54h06DklPMQXkzB6w7egDC11pqHMcra+e1R5mcqQp2rCRm/n2/6gkXm/sEomSpPnuv6O7cZXIjPPN5lotgCOw2aahtLFh5hiqFc+nFNzgqKtK30t0/YkqTsUvp+Lr7waWTNX4hEA98/n0Y0L5EATiE7HXnF1YOIo= X-MS-TrafficTypeDiagnostic: BN7PR07MB4900: X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 20:YqQQLUp8NGQCdGmn1+h1yY5ZkpG5OyHpRoCYJW69bUbLXWIcXYG8/Q+JnU7UEwrCsm9VSRkEtZ3wlk4PFWg4g0CvJZkPQRYVu2ndCbX4/IMD/GwW2NqDJijzJjjVCdfXREJx/477Aq5MQ4uxoD2Pm9TDmzodHK8KCQ+XM40f9ZJnf0piQJmjANBflU90jKtxH0Y7srLEgGV5rs7XeB2uBCMW9d9G6hxUGsKYUIFH+WgERstC17NEttEBhom6XrQCKPPvfnH48nE5s0XWxWkDgcX8IITppyDwaUtfRksgUX99TIoJlG+dgs2/DPZXi86Oy6guI+/cTwi6ndv5Ll1HJ1rjavMPN0DCV8E87GtN39OEi+C3Y20HMMYEZVYN5lHq3/XfyKEc01eKkh39AMedGrxFae7wH/FY6Os2dcJlurTwTUQuIyIL53En3b/UuEje6rjqiNlscIehAsDiXsDWtpqVjUU5Gc+J+qB1lA6bUakWSbJ2yV8i5066YWTimjnUpoockdlWXuuwI+cjGvSvbduyZvpV8ZFsnbFNIpdWuQaI/MpRktZnR71GCUOSQt1iDPEn7AeP2AwaFchVYuZVlCCNhyolF+H5Sh4bh/Xv2oc= X-Microsoft-Antispam-PRVS: <BN7PR07MB4900FDA91988CA213B901B01F8000@BN7PR07MB4900.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(192374486261705); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:BN7PR07MB4900; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4900; X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 4:DXJ8Zs0WBAYu01bxT3baUvqPocatlxfNuWvzjPeHxjndFJS2Rg3o7SfWGx5vGiy48E3DyDwBVm/4AQKXtTn5IXxIa7Wn4ST8P9z7GmmyJTcKtzBiswvD8GdYa/UXdAajfILmeHStSs1Q7OTHSf6y/7xrlokHAUVledhqwqlCVEnSTnDL4mkXCKMpfD3rxwXgrDf+lk9Ziz7HI7/wLT9fnFGP27SA92BtIRA1hqJQGp+HO1vZrxxRsH1Lo8LcTDeR+0/61/aodRIrhS6mvVuhswi9OpSU5IpSnE4aUU5I8CvUri66xRt/h4tRXUuOKxFu0iuHhoYlKKjfuZ3/Tb+xRAt5fmlzWyWOCKiMaG6fH88= X-Forefront-PRVS: 07880C4932 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(136003)(396003)(376002)(346002)(39850400004)(199004)(189003)(72206003)(47776003)(6512007)(186003)(486006)(16526019)(105586002)(1857600001)(476003)(53936002)(956004)(2616005)(54906003)(6486002)(66066001)(8936002)(107886003)(316002)(50466002)(97736004)(110136005)(16586007)(14444005)(81166006)(44832011)(68736007)(51416003)(25786009)(52116002)(2906002)(478600001)(48376002)(7736002)(42882007)(6666003)(36756003)(4326008)(8676002)(81156014)(55236004)(386003)(6506007)(5660300001)(26005)(6116002)(3846002)(50226002)(305945005)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4900; H:ajoseph83.caveonetworks.com.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN7PR07MB4900; 23:UkR/sbUQvYNqVicz+5IDl8e+6tR0oekwENiMrf/2n?= O4QSg3oXX3LDe8GCSTtH5/Ai5alSdggs23Bn2ndGQGZYNlh7FVKcuQz7V9jUrhl1j0uXZ5oaJ2QtVZ4xFTRXDUjLoFEd34Razo9+6n7/nFTPgUnrDc0QOyYXwCFTAyui+1wvX6DB6+BBusaExcynqvsRjlbYW024iQacL+LDPA1bFYxBui2owZh6G2sy4ctHNy2aTf0h0NKssoRh3+YziNNFLRvJwFA1pxBOp6/GPyoddVdvlLN+yjJ+nS6IC1eLsPG+CSWaT5SV/dGWqMAcari2pfqUxeOno1UkjVvFh+MZq6eJx/X2LJdh1iEOnnedSqMFl4uOs6TvDBXIX5B2bqEjOBCRfClqR2I4VLNzhDpq7hHZfYclrLH1w3r+0idQq1+wK6UYU6IuvwuulJXtJE4RDNuFgPZ4t5Ax2c6PxRtvlDsxpz767YYVb/A5W+WaYTF5PUIcmBMWlFT04FKZbbe4uWj/QT+7MsgfBI9cZID8DZdEyQI1MmV2Jg/s53fMrnaRzt1Iu8LIC/6SUWoK4ikNOsUYMSnOkbKM3/vgM64c+TBvWDYj94FrPkmKpMkdAQsC40qxE+DdTLJ828/D8jC8QynaYuT+yjoUH4CO9ZvSl8z4Hz79HlqnbbpuZBLRTweggcO7azzHipM7a2oeKNybuabjuZuyaAtfRBXkxpgNKS7FearxI8eKmOqy+sVvlUsENsNBM2u++BCV+B30u0eHvBkiLZHAOkUD1lxhu/tMU5wEoOfVWy8Cb2AAPMnIF+TTw1Fcjk1rhclGp03N5r8uiKCao/1HSz7jCVppXXQKZqTnKH4PVxSVN85ww4MvfCp0U1/4TOLW1AWOm2ynwl2JWXFr6pcU7wClo15e1ihgj0QAA1FniwSt3C4sEs7WM3im5jYu/b6c/vAo3Qr3jsRoRG0j8p7whga/GB+Prht5EiCvA0gBLTpY1HJAt0gn2gPmBlJHjgz3UnrqnI9Otr7Mnxc7NF1SP92RW4C4Tt2DIl1a0PB5Zba+NQvFGOQHqeehijduQCNvMaZXinFrob0OxCUOOxkTsXvkgAw/3sa346TbBSsnCS2JfWaZBdVxAXkHrKP68xqVEHcRSE0EXeXU5Pa25P8ZVzyqIUiixjiePk/XsKj4gF9dhOvoSqIRPluAdBQv3RvbL6AUv1gPMicMHjoVeXc8yaZd4XjMAAg48NRWYjBmRGCAiFJVdTkhDbAsQbRFUNPkI63z0VsUaRz X-Microsoft-Antispam-Message-Info: WBhzKyF3AXP3aioc8dTbY1R/EhMaw1NTWpiQQIfrWFlrZw3pLqUzGtT3aY+Wjzwr4I9jXpoUbk3L6ca44gB/LAz3SLzKndGa9r5BBClohhhe5SUGP2QjC7MqYekkhKQP8GQN204wwC6JKV6OfTf4D01v4a68G91i3ceNEa8qM1NMbYZokcKvW2e2W/CMUJTcLoznSoZ/Frg95UBKEnWAvmgD6UvSMsPQq4+DrYZ+PZBUmhwliip5/Mh5gx58PIFE/fS1PVNmGvB1yS/muV9YK00IGwugWHF+ShvaKjE2cNTUaiBdmUGzXJtOCtCD0qFu+e+wXfPrrtv7TgbWALOavFmzhT/awc+owGaiucOs0JM= X-Microsoft-Exchange-Diagnostics: 1; BN7PR07MB4900; 6:NLpuwKgJ6cNVCwEVfOu0oL3T9imJxLIeNRs6XexZn71pZoH1sr8ILLd5mD/JM2DH7h29dCNfv113u8uJwgYWOfBsIVCVqBrrnDBfllhd01/PPiw4nuZqK4shA2p9RT2DgyOyvJ28rUMY7hwDC0ZbDlKXVZGxlFrJ+ihFoyw0eM7QHkKKsc1Mk+cjIqg0pU7TnqWNOfRvdJNU5jQynjmyDLoCEoiCxbG1cGP7ZnfOK57NER49h0VD0DtrRZWo/T/9Wgt/GozcbC+8szZCiFLyv8cIPENuXAQoGLCmQjOfEePyEANzl83CpNP4GpsUDG2NB8hmoSFIoz+Ao4PACbsq6m+YlbkSMvWP4cJpvogi5ZMEocHJNgBzKpXAKaj2d+nfPBjerb/ibSm6NE1wYTCqpzdiaB52HGtVz1uY+Dh3aKbcKS9md/oYOOaXoc+xbHBX9FG5iYjCZkD0kLKwFPcluw==; 5:LUhs4jC/nN+Z85eUnM7MgWc2LnDuTlseTornQSyW0H1H/PB/zPIpWaFT7a9nCPJ8jo+NX1E370Rj65xp2RjhY5vxYwGXOBONM2Oo+ricG3vM9xwf8RtPk2f/m7aI7ow2XYkjoXfXI47OplFhNfEzBuE3+zh/48SIaJbscWXkQf0=; 7:s35YXQwmNUC8BILp9gqqaSUwhKb5i31U8pFdwbd4ihL+4Ze6VvWHsCa2OWW/WECAL6zqn7ymHSPlDkzaXeYv7Yc47dfGTWAIWfQ8GU6UQs/SpOQGzN+eXWjg2I6/GQ4Qsn3+YmmpD/s0BBM45rKdjroaszj+JU7EhsD4FuRAcN+UGb4hQmP1h+arm0fTkI0qoEqdxn5FGQ7PzQgd/H32IduZQTv1BPhRckxArCvByIIs5fhOedUMG32Ws8PMsyA8 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2018 05:56:32.3934 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0765fd3-e478-4ff0-c7ea-08d61486ab62 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR07MB4900 Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
examples/ipsec-secgw: fix wrong session size
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Anoob Joseph
Sept. 7, 2018, 5:55 a.m. UTC
Crypto devices, which support lookaside protocol, exposes security session size in addition to the crypto private symmetric session data size. For applications using the security capabilities, both these sizes need to be considered. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com> Signed-off-by: Archana Muniganti <muniganti.archana@caviumnetworks.com> --- examples/ipsec-secgw/ipsec-secgw.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
Comments
Hi Akhil, Radu, Can you please review this patch and let me know your thoughts? Anoob On 07-09-2018 11:25, Anoob Joseph wrote: > Crypto devices, which support lookaside protocol, exposes security > session size in addition to the crypto private symmetric session data > size. For applications using the security capabilities, both these > sizes need to be considered. > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") > > Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com> > Signed-off-by: Archana Muniganti <muniganti.archana@caviumnetworks.com> > --- > examples/ipsec-secgw/ipsec-secgw.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c > index b45b87b..47ac26a 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -1392,9 +1392,27 @@ cryptodevs_init(void) > > uint32_t max_sess_sz = 0, sess_sz; > for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) { > + void *sec_ctx; > + > + /* Get crypto priv session size */ > sess_sz = rte_cryptodev_sym_get_private_session_size(cdev_id); > if (sess_sz > max_sess_sz) > max_sess_sz = sess_sz; > + > + /* > + * If crypto device is security capable, need to check the > + * size of security session as well. > + */ > + > + /* Get security context of the crypto device */ > + sec_ctx = rte_cryptodev_get_sec_ctx(cdev_id); > + if (sec_ctx == NULL) > + continue; > + > + /* Get size of security session */ > + sess_sz = rte_security_session_get_size(sec_ctx); > + if (sess_sz > max_sess_sz) > + max_sess_sz = sess_sz; > } > RTE_ETH_FOREACH_DEV(port_id) { > void *sec_ctx;
On 9/7/2018 11:25 AM, Anoob Joseph wrote: > Crypto devices, which support lookaside protocol, exposes security > session size in addition to the crypto private symmetric session data > size. For applications using the security capabilities, both these > sizes need to be considered. > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") > > Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com> > Signed-off-by: Archana Muniganti <muniganti.archana@caviumnetworks.com> > --- > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
On 9/7/2018 11:25 AM, Anoob Joseph wrote: > Crypto devices, which support lookaside protocol, exposes security > session size in addition to the crypto private symmetric session data > size. For applications using the security capabilities, both these > sizes need to be considered. > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") > > Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com> > Signed-off-by: Archana Muniganti <muniganti.archana@caviumnetworks.com> > --- > examples/ipsec-secgw/ipsec-secgw.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > cc: stable@dpdk.org Applied to dpdk-next-crypto Thanks
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index b45b87b..47ac26a 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1392,9 +1392,27 @@ cryptodevs_init(void) uint32_t max_sess_sz = 0, sess_sz; for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) { + void *sec_ctx; + + /* Get crypto priv session size */ sess_sz = rte_cryptodev_sym_get_private_session_size(cdev_id); if (sess_sz > max_sess_sz) max_sess_sz = sess_sz; + + /* + * If crypto device is security capable, need to check the + * size of security session as well. + */ + + /* Get security context of the crypto device */ + sec_ctx = rte_cryptodev_get_sec_ctx(cdev_id); + if (sec_ctx == NULL) + continue; + + /* Get size of security session */ + sess_sz = rte_security_session_get_size(sec_ctx); + if (sess_sz > max_sess_sz) + max_sess_sz = sess_sz; } RTE_ETH_FOREACH_DEV(port_id) { void *sec_ctx;