[v2,10/12] net/mvpp2: align documentation with MUSDK 18.09

  From: Natalie Samsonov <nsamsono@marvell.com>

Update documentation to align with MUSDK 18.09.

Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
---
 doc/guides/nics/mvpp2.rst | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)
  

On 9/4/2018 2:49 PM, Tomasz Duszynski wrote:
> From: Natalie Samsonov <nsamsono@marvell.com>
> 
> Update documentation to align with MUSDK 18.09.
> 
> Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
> ---
>  doc/guides/nics/mvpp2.rst | 26 ++++++++++++--------------
>  1 file changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/doc/guides/nics/mvpp2.rst b/doc/guides/nics/mvpp2.rst
> index a452c8a..3b3f8c6 100644
> --- a/doc/guides/nics/mvpp2.rst
> +++ b/doc/guides/nics/mvpp2.rst
> @@ -74,6 +74,7 @@ Features of the MVPP2 PMD are:
>  - QoS
>  - RX flow control
>  - TX queue start/stop
> +- Scattered TX frames
>  
>  
>  Limitations
> @@ -96,19 +97,19 @@ Prerequisites
>  
>    .. code-block:: console
>  
> -     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10
> +     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09

There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older
versions. It is hard to trace this dependency, what do you think having a matrix
in DPDK documentation showing which DPDK version supports which MUSDK?
  

19/09/2018 19:15, Ferruh Yigit:
> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote:
> > From: Natalie Samsonov <nsamsono@marvell.com>
> > --- a/doc/guides/nics/mvpp2.rst
> > +++ b/doc/guides/nics/mvpp2.rst
> > -     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10
> > +     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09
> 
> There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older
> versions. It is hard to trace this dependency, what do you think having a matrix
> in DPDK documentation showing which DPDK version supports which MUSDK?

It does not compile even with MUSDK 18.09.

With MUSDK 18.09, the error is:
	drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_NUM' undeclared

The explanation is in MUSDK:
commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce
Author: Dmitri Epshtein <dima@marvell.com>
Date:   Mon Nov 20 10:38:31 2017 +0200

    sam: remove SAM_HW_RING_NUM from APIs
    
    Use function:
    u32 sam_get_num_cios(u32 inst);

As a consequence, next-net cannot be pulled!
  

On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
> 19/09/2018 19:15, Ferruh Yigit:
>> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote:
>>> From: Natalie Samsonov <nsamsono@marvell.com>
>>> --- a/doc/guides/nics/mvpp2.rst
>>> +++ b/doc/guides/nics/mvpp2.rst
>>> -     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10
>>> +     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09
>>
>> There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older
>> versions. It is hard to trace this dependency, what do you think having a matrix
>> in DPDK documentation showing which DPDK version supports which MUSDK?
> 
> It does not compile even with MUSDK 18.09.
> 
> With MUSDK 18.09, the error is:
> 	drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_NUM' undeclared

I confirm same error. I wasn't building with crypto PMD enabled so not caught it.

> 
> The explanation is in MUSDK:
> commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce
> Author: Dmitri Epshtein <dima@marvell.com>
> Date:   Mon Nov 20 10:38:31 2017 +0200
> 
>     sam: remove SAM_HW_RING_NUM from APIs
>     
>     Use function:
>     u32 sam_get_num_cios(u32 inst);
> 
> As a consequence, next-net cannot be pulled!

Got it, should I drop the patchset from tree?
  

Hi Ferruh,

pon., 24 wrz 2018 o 13:38 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>
> On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
> > 19/09/2018 19:15, Ferruh Yigit:
> >> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote:
> >>> From: Natalie Samsonov <nsamsono@marvell.com>
> >>> --- a/doc/guides/nics/mvpp2.rst
> >>> +++ b/doc/guides/nics/mvpp2.rst
> >>> -     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10
> >>> +     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09
> >>
> >> There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older
> >> versions. It is hard to trace this dependency, what do you think having a matrix
> >> in DPDK documentation showing which DPDK version supports which MUSDK?
> >
> > It does not compile even with MUSDK 18.09.
> >
> > With MUSDK 18.09, the error is:
> >       drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_NUM' undeclared
>
> I confirm same error. I wasn't building with crypto PMD enabled so not caught it.
>
> >
> > The explanation is in MUSDK:
> > commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce
> > Author: Dmitri Epshtein <dima@marvell.com>
> > Date:   Mon Nov 20 10:38:31 2017 +0200
> >
> >     sam: remove SAM_HW_RING_NUM from APIs
> >
> >     Use function:
> >     u32 sam_get_num_cios(u32 inst);
> >
> > As a consequence, next-net cannot be pulled!
>
> Got it, should I drop the patchset from tree?

We're checking the error and will provide fix asap. Please let know if
this should be another version of the entire patchset or fix on top.
Sorry for the problems.

Best regards,
Marcin
  

On 9/24/2018 12:51 PM, Marcin Wojtas wrote:
> Hi Ferruh,
> 
> pon., 24 wrz 2018 o 13:38 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>>
>> On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
>>> 19/09/2018 19:15, Ferruh Yigit:
>>>> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote:
>>>>> From: Natalie Samsonov <nsamsono@marvell.com>
>>>>> --- a/doc/guides/nics/mvpp2.rst
>>>>> +++ b/doc/guides/nics/mvpp2.rst
>>>>> -     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10
>>>>> +     git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09
>>>>
>>>> There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older
>>>> versions. It is hard to trace this dependency, what do you think having a matrix
>>>> in DPDK documentation showing which DPDK version supports which MUSDK?
>>>
>>> It does not compile even with MUSDK 18.09.
>>>
>>> With MUSDK 18.09, the error is:
>>>       drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_NUM' undeclared
>>
>> I confirm same error. I wasn't building with crypto PMD enabled so not caught it.
>>
>>>
>>> The explanation is in MUSDK:
>>> commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce
>>> Author: Dmitri Epshtein <dima@marvell.com>
>>> Date:   Mon Nov 20 10:38:31 2017 +0200
>>>
>>>     sam: remove SAM_HW_RING_NUM from APIs
>>>
>>>     Use function:
>>>     u32 sam_get_num_cios(u32 inst);
>>>
>>> As a consequence, next-net cannot be pulled!
>>
>> Got it, should I drop the patchset from tree?
> 
> We're checking the error and will provide fix asap. Please let know if
> this should be another version of the entire patchset or fix on top.

There is another comment from Thomas (mvpp2_tm.png).

Both "fix on top" and "new version" is OK for me, pick whichever easy for you.
For "fix on top", I will squash fixes to original commits, so fixes should be
separate patches with a information which commit it targets.

But overall build should not be broken, it should be clear in which commit
dependency changed to 18.09. Let call the commit that switch happens X,
all commits before X should compile successfully with 17.10, commit X and all
following commits should be compile successfully with 18.09.

> Sorry for the problems.
> 
> Best regards,
> Marcin
>
  

24/09/2018 13:36, Ferruh Yigit:
> On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
> > As a consequence, next-net cannot be pulled!
> 
> Got it, should I drop the patchset from tree?

Yes I think it's better to re-consider this patchset later.
  

pon., 24 wrz 2018 o 14:44 Thomas Monjalon <thomas@monjalon.net> napisał(a):
>
> 24/09/2018 13:36, Ferruh Yigit:
> > On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
> > > As a consequence, next-net cannot be pulled!
> >
> > Got it, should I drop the patchset from tree?
>
> Yes I think it's better to re-consider this patchset later.
>
>

Ok, complete, new version of it will be re-sent to the lists.

Best regards,
Marcin
  

On 9/24/2018 1:48 PM, Marcin Wojtas wrote:
> pon., 24 wrz 2018 o 14:44 Thomas Monjalon <thomas@monjalon.net> napisał(a):
>>
>> 24/09/2018 13:36, Ferruh Yigit:
>>> On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
>>>> As a consequence, next-net cannot be pulled!
>>>
>>> Got it, should I drop the patchset from tree?
>>
>> Yes I think it's better to re-consider this patchset later.
>>
>>
> 
> Ok, complete, new version of it will be re-sent to the lists.

OK, patch will be dropped from the next-net for now.

> 
> Best regards,
> Marcin
>
  

On 24.09.2018 14:50, Ferruh Yigit wrote:
> On 9/24/2018 1:48 PM, Marcin Wojtas wrote:
>> pon., 24 wrz 2018 o 14:44 Thomas Monjalon <thomas@monjalon.net> napisał(a):
>>>
>>> 24/09/2018 13:36, Ferruh Yigit:
>>>> On 9/23/2018 11:40 PM, Thomas Monjalon wrote:
>>>>> As a consequence, next-net cannot be pulled!
>>>>
>>>> Got it, should I drop the patchset from tree?
>>>
>>> Yes I think it's better to re-consider this patchset later.
>>>
>>>
>>
>> Ok, complete, new version of it will be re-sent to the lists.
> 
> OK, patch will be dropped from the next-net for now.

I will provide the new patchset shortly with following patch:
http://patches.dpdk.org/patch/44255/
already "squashed"/applied.  This is the patch for updating mvsam to
MUSDK 18.09 which solves the problem you experience but I guess it goes
to next-crypto.  That way I hope there would be no problem with merging
next-crypto and next-net will be able to compile.

Best regards
Andrzej