diff mbox series

[1/6] crypto/mvsam: fix shared library build

Message ID 1535118895-6505-2-git-send-email-tdu@semihalf.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series crypto/mvsam: add new features and fixes |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tomasz Duszynski Aug. 24, 2018, 1:54 p.m. UTC 
  Add missing rte_kvargs library dependency. Without that
shared library build fails due to unresolved rte_kvargs_* symbols.

Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions")
Cc: pablo.de.lara.guarch@intel.com

Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
 drivers/crypto/mvsam/Makefile       | 2 +-
 drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Akhil Goyal Sept. 17, 2018, 2 p.m. UTC | #1 
Please add cc: stable@dpdk.org for the fixes patches in the next version.

On 8/24/2018 7:24 PM, Tomasz Duszynski wrote:
> Add missing rte_kvargs library dependency. Without that
> shared library build fails due to unresolved rte_kvargs_* symbols.
>
> Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions")
> Cc: pablo.de.lara.guarch@intel.com
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
>   drivers/crypto/mvsam/Makefile       | 2 +-
>   drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/mvsam/Makefile b/drivers/crypto/mvsam/Makefile
> index c3dc72c..3290147 100644
> --- a/drivers/crypto/mvsam/Makefile
> +++ b/drivers/crypto/mvsam/Makefile
> @@ -31,7 +31,7 @@ EXPORT_MAP := rte_pmd_mvsam_version.map
>   
>   # external library dependencies
>   LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk
> -LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
> +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_kvargs
>   LDLIBS += -lrte_cryptodev
>   LDLIBS += -lrte_bus_vdev
>   
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> index 73eff75..9d130b1 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
> @@ -11,6 +11,7 @@
>   #include <rte_bus_vdev.h>
>   #include <rte_malloc.h>
>   #include <rte_cpuflags.h>
> +#include <rte_kvargs.h>
>   
>   #include "rte_mrvl_pmd_private.h"
>
diff mbox series

Patch

diff --git a/drivers/crypto/mvsam/Makefile b/drivers/crypto/mvsam/Makefile
index c3dc72c..3290147 100644
--- a/drivers/crypto/mvsam/Makefile
+++ b/drivers/crypto/mvsam/Makefile
@@ -31,7 +31,7 @@  EXPORT_MAP := rte_pmd_mvsam_version.map
 
 # external library dependencies
 LDLIBS += -L$(LIBMUSDK_PATH)/lib -lmusdk
-LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_kvargs
 LDLIBS += -lrte_cryptodev
 LDLIBS += -lrte_bus_vdev
 
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 73eff75..9d130b1 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -11,6 +11,7 @@ 
 #include <rte_bus_vdev.h>
 #include <rte_malloc.h>
 #include <rte_cpuflags.h>
+#include <rte_kvargs.h>
 
 #include "rte_mrvl_pmd_private.h"