From patchwork Wed Aug 1 02:43:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhao1, Wei" X-Patchwork-Id: 43494 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66B265689; Wed, 1 Aug 2018 05:05:33 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C04694F9B for ; Wed, 1 Aug 2018 05:05:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2018 20:05:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,430,1526367600"; d="scan'208";a="77253599" Received: from dpdk6.bj.intel.com ([172.16.182.94]) by fmsmga001.fm.intel.com with ESMTP; 31 Jul 2018 20:05:29 -0700 From: Wei Zhao To: dev@dpdk.org Cc: qi.z.zhang@intel.com, Wei Zhao Date: Wed, 1 Aug 2018 10:43:34 +0800 Message-Id: <1533091414-4912-1-git-send-email-wei.zhao1@intel.com> X-Mailer: git-send-email 2.7.5 Subject: [dpdk-dev] [PATCH] net/i40e: revert fix FDIR check programming ret error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This reverts commit 7546dc4a1331340ecb665af9af0a005bb8b657c8. In i40e FDIR PMD code for checking programming status, when the action of add FDIR filter is ok, i40e NIC will not write back to programming status descriptor, so if PMD code check DD is not done after period of time dealy, it means the add or remove filter action is ok. It only write back descriptor when fail. So, there is no issue for the orignal code. Fixes: 7546dc4a1331 ("net/i40e: fix FDIR check programming status error") Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_fdir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 2b299c7..d41601a 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1360,8 +1360,6 @@ i40e_check_fdir_programming_status(struct i40e_rx_queue *rxq) I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); else I40E_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_tail - 1); - } else { - ret = -1; } return ret;