app/test-pmd: Fix buffer leak in tm cmdline
Checks
Commit Message
Free the buffer allocated for shared_shaper_id array in
case of configuration without shared shapers.
Signed-off-by: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>
---
app/test-pmd/cmdline_tm.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nithin Dabilpuram
> Sent: Wednesday, July 4, 2018 11:18 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; kkanas@caviumnetworks.com; Nithin Dabilpuram
> <nithin.dabilpuram@cavium.com>
> Subject: [dpdk-dev] [PATCH] app/test-pmd: Fix buffer leak in tm cmdline
>
> Free the buffer allocated for shared_shaper_id array in case of configuration
> without shared shapers.
>
> Signed-off-by: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>
> ---
> app/test-pmd/cmdline_tm.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
@@ -1599,10 +1599,12 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result,
np.shaper_profile_id = res->shaper_profile_id;
np.n_shared_shapers = n_shared_shapers;
- if (np.n_shared_shapers)
+ if (np.n_shared_shapers) {
np.shared_shaper_id = &shared_shaper_id[0];
- else
- np.shared_shaper_id = NULL;
+ } else {
+ free(shared_shaper_id);
+ shared_shaper_id = NULL;
+ }
np.nonleaf.n_sp_priorities = res->n_sp_priorities;
np.stats_mask = res->stats_mask;
@@ -1758,10 +1760,12 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result,
np.n_shared_shapers = n_shared_shapers;
- if (np.n_shared_shapers)
+ if (np.n_shared_shapers) {
np.shared_shaper_id = &shared_shaper_id[0];
- else
- np.shared_shaper_id = NULL;
+ } else {
+ free(shared_shaper_id);
+ shared_shaper_id = NULL;
+ }
np.leaf.cman = res->cman_mode;
np.leaf.wred.wred_profile_id = res->wred_profile_id;