From patchwork Wed Jul 4 09:43:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 42214 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67EB01BF35; Wed, 4 Jul 2018 11:45:50 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30042.outbound.protection.outlook.com [40.107.3.42]) by dpdk.org (Postfix) with ESMTP id EF28E1BE7B for ; Wed, 4 Jul 2018 11:45:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ihYnQrMRraQQYHOBkvDo3prICPrk061VT+pWZzETp4=; b=aITHkCMW0FgcC3QOU4EHbKNltZZph58/EOSqxeILvlS0L+7qZgV1lBAmm/sTSOg2h79eeUCcdh9Fxr+/mHzedjiAagSXbhutDuYOxMlsilym3nDSbtwbDN3WJLEgJxWvT3DPD970HTL3xt8MwPswqJomsdSY7/BCwLZcNjOZdys= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by DB4PR04MB0765.eurprd04.prod.outlook.com (2a01:111:e400:984d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.25; Wed, 4 Jul 2018 09:45:38 +0000 From: Hemant Agrawal To: dev@dpdk.org Cc: Pavan Nikhilesh Date: Wed, 4 Jul 2018 15:13:47 +0530 Message-Id: <1530697431-1244-12-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> References: <1529574244-18997-1-git-send-email-hemant.agrawal@nxp.com> <1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR0101CA0008.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::18) To DB4PR04MB0765.eurprd04.prod.outlook.com (2a01:111:e400:984d::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa1faa38-3dda-48ec-2ac5-08d5e192e65d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DB4PR04MB0765; X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0765; 3:bSnc5BfCf0/hUQfU1uyhOswvAawr9Lx53jsF4a7O5Q82nSyHDovXdyFhwjnvG8uP5tJ3IBmNt021zyC/Mp/v7ZcO1qGJA3RwP2zd+lLSixbE4yWfuX/PuAOm4sJmV2sAnZdohHAeRaaUGa1Cr+A38knl4So0cKqx3VaF5seky+NmiNhYEOOYIIKN9nwK5qJQtS+yRMT9uBZH0XngnX+Op1Apm616kGSwMPR51zrzwIWOhSZ8cEtYuBpATzTGDYTG; 25:V7bRX6dhYd4AIBvH9kK0OytNPoYiGHGakrK3x6kptFoE/tsKMG3+OVWCZoRtOLpJvagIW67meXJ84YHYlGjbHNfkNcpeJuG31RHzB/MxxxEyaQVRGJU1skxxzYRfZskRhHTTT8QzE1f4eAcMWtXoxgWY47Z7nC+p+BcsFMegqo6dY5iR4zgYDEitst7tkBc8kJ+CUunN+0pV9i9qItg7fmCGvbUeH7jcyYXmz9EfX+nJP5t3MFSJIulcVho3PtYJ0HjxxE3NlYUXZtVu3o6a6gzdCb+aOuuCVqNFP5gCm+r5Rx5wH5WWAkGQvgpfddtAY4W/MwK4919GpSlehXCKag==; 31:rXX+u5iOQhZFJjC6g1YtKwcqUU/yJJgMMZuSuvrHaLHLQ88eWv9WBwT4S/SPYNMXVcaNh0NUfli43HFt8SXZMyoUpgFS4nuta5Wmr/vYRzPuf8+ZC1DcZXLi+i2/XIfAhLF9Kz1TOEcRWSQab0HDc+NwA8hpqXVRkrEBoJchNo9YKNOlsC02CySnEevjDd+q2D8xGwdWWtjd8mZkEvZouPbOOs5bK9OE2GT3HGWwJfo= X-MS-TrafficTypeDiagnostic: DB4PR04MB0765: X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0765; 20:9v5zlSQ7nRsZ/htgL8dZv5S4w/vqgLAZa16lw73ONbHVlNXggIEBib85CQrOO9omI3AdhfpKJyHoll3I966bt+o1pGigjQynsmSnjS595+ENUv1G6nxmBRuj4Te9Dg47Y8ljJgBjeV5/4bCKLK8o8JGex4KPn7OFc++ZjLaF0usbN3QmDlLoaQ92WZaos57w23X6IbI99om8qUDHhmi3YbcO5bVsWq7f1WZ4OnRk5+zwRyVg7VPmzzi1KhSjODd3ud5JgJuYOBFo6qJNTpoCyJvm2WwvQDDJu+gz3uf72ns74CcR6xhFEpgp/ZtEQb8ys2/pRZnwSIoVmIRRh34cw5ZXBbiD28xDXogYaSwa+0C1T2WeZkLTnp3thqh0qslN73nntYVovmoKCiOIdbW5X1NfWJlLFiqdGAeXDv2KthWn8neX018/0+qf5Hi5GrAq/D163zo18Y2YMF5NbCcG6MWcl6pbxu8uUHTg+Lte/7HC0QK47s10gGPMB3fjViZq; 4:rKj5t48TfGAzie0bJUbNmvcSedoIPGNYIrY8d61uNJz1i7PRJs8UaG6R4uZ59Ilp1k6oZ9jN+TGCQwL5QhrlJrkh1Be/ZEL6KAD0pbnibDjCpeMVqchrxJAnEcAx0VpMGunyuTWpLTmTMZs4EJZoPBaxteskDkT6gARwr1MX4KUPJiAbfliA+2Y8qBtwvqnmtiyT8xfWWs/22QXQsDkyGnmpLwkKbh7I1Te3NaypyTa9VFZ9YIqntD8+i62IlPCKwEZytjYZc2m2AOvLzyRD4I2Ex6rnI8Y7ut4DezeCprM+/G3dR955ooxvLCq82hEf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DB4PR04MB0765; BCL:0; PCL:0; RULEID:; SRVR:DB4PR04MB0765; X-Forefront-PRVS: 0723A02764 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(136003)(346002)(366004)(199004)(189003)(6512007)(11346002)(476003)(386003)(6506007)(4326008)(55236004)(956004)(2616005)(5660300001)(44832011)(105586002)(575784001)(68736007)(16526019)(53936002)(446003)(50226002)(316002)(6666003)(5009440100003)(36756003)(16586007)(2351001)(6916009)(106356001)(186003)(86362001)(26005)(6486002)(97736004)(305945005)(81166006)(7736002)(8936002)(66066001)(8676002)(478600001)(25786009)(51416003)(486006)(76176011)(3846002)(6116002)(81156014)(48376002)(50466002)(52116002)(2906002)(47776003)(2361001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR04MB0765; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB4PR04MB0765; 23:yt8qynRXYamvLtGPkN4sPN1wHUVdubKG+IdN3GBvB?= 8KhcitZfuyFHD/fbHHieLWYdQbHGpiCwtZpJhPYn5E4zBY+SiVkXFOqKmIfdAii93B9bKCXLIYtRNZ33WQ6jhJN5ThuDQPPr8At8W1Zy9nOoziyJQqGfaCSSLyJqpDmy80dWvMYb6YLTIbg+ONr9PVa/N//T+UNwRqzCzYv0QDHZCL3IX/FEkQSYjX14BsK3TBKOhgFSexg10tlat0BgFLa/0KCmlAwpFBJJ+slFmui1o4Caxjwq2jLyZRgH7R4+otAGc6PlyFLWpGuiPA/K5NrBvuHgg/f97Hwp34+DcnjvmmhbFm71An6ikUBXIpToHUTnlq1njOPNVeQv/NqEFCtX2qwL5mJl2XPX5L2uWDzuygiB+QVhZ1YtA4PNqI2B1aHnXMNTi6TRRi7uYtpkAZCKQZJwpZTNA6cY/brmD361W4ivmishIHIDZFLTIIoeeRabmQiKrxBF6mYyGNg2rLbXv/ZHlyM3o+HB0cDjHMlBfKmE7ib1iJVBB9s7fWhkTe5Ql2vLaa8y2N8tp2UnpBYTCA3CFsbWTxzEExQSHDxK5BfXEmVWV69JksL6ow0E1fPGTlOM6vG6Nol3vA/syDuPSAM4krnUu6GILRlCg6JAuIWDrWrDp2vBEbzWXLkX98sIInJFMaP7MrtRo1YXVcllDNFCEQLYgXaz+3cPrghX7wvZu47sAE/19S1b5ZvFHr5qBWxdcCzDsCsuV76Trvd6m6dMDgxamW87JaiBKd+1fhD89xqkLuDJEfxvYAhy1oek50UdHtU62QO6KYR+YAuyYUvMhvie6T6AULeCeRgpOVoF4LDpy2i6HoQnBE30sTbMRWddXsLRNcUo2QgPMomjygcOTkJpgQhgMwFVaDGmjoIIjX0JF8+z2MX5wslmswZNk9wF0H/Sdq+0PRYZMf8XejqcE5nTti6gZCRbcAe4RssYRBjWDqy8zbM0ces9DC429wWQSDR7LmQJFUD7gSLeSo2ePB1terYjPna8Hrh6Nz2iCbqU/Y6QShbOcujabxVOE7UxhYWE/k3YQXfu+77puSBcMBrpjvYtvn4z1rvyUCy28mAYxGHe3FxF6ICYb0UrKKCb1JbnHTjJmUse9kBoRPiBX6tALQBELeLtR1uUM22m2ckWB/hwQjjWXbudgVns2XGHbyZH0THhPUg0vtJYxNSRf3dfQx+7wew5QC/qvaZwskjBfClJwutOY7JS/kvjMWb9P09H+c+ez/1cutFHnDY70LrY3Ec4xeeG86O7CGmEyxa1EnZnetZPirW5kvI37APT5SBbFOvWuZQDa/Q X-Microsoft-Antispam-Message-Info: 5opqAwCzLyaFc+/f9//WwQbVN0SRAR7JA3d3myECHP7pxCnIRr9YKM4DvIMUlhW7W9DwkaMVB4TPkPLXJfglggrnBWuPZibKg2DVamL0BUrzEwbmGS3xt9xBgKLOmWD1A5OH6o02kcAmk6IG+hcXauisH7AVgZTVWIoo9I/kmcH+FPPrj/GXba72Eg3ybvLkzUTW38vJK6AX8WTQnefFuqU1ibqve97BGzZ6cy3Q3T/Mx++5xvMCNryomvWnEZuuYtvWs4o2QriZkZL4Ye3E+Y1VcEoYvArLOMjOyLblkKcc2j1VWf/GRkBxceHzQim6WrCYLzkqOIrXQEfCcrmsygf7ThIroE5Sn0aUPoy22/8= X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0765; 6:gqv3v0eDOBi74Yv/HZqb4qbDpoUVDV5nAqv3mYwZPxU50OyVLhCRq2kDbGA2KMUZTxLoVHjlVwJcE9cX25uS8koQ+dwjuxNimOb7aNBVHwCcPBxyD1UuX4qJX50lp7OqxTkP+oV0+qEDMc/jrLEu8tXNmkFsfmxI6ceMxvdIVzmkeKsBzY5RtswlL9YidIwMpV49KE07m965Y6WIOwYE3n5GKLFQgKJ5N+tDKi5wtA4rvioUNjj1WDqyIlfyypGjPZhUKWtVD+rkZsmkcze7jWPRWvpvBphW+LL7EpjanIjRJp+8w9LaXK+AFlZ3W2lp3yVHu9AYrQa8oAneeGq5N+X6C3tfO1o3X6iuijs9E+PGh9eNFUHLZnNA1sqnAJZVUnBZQGl7U9ky8f3fI4/bJ0jzxNQugnfsbCFr31xzEed3WfikqP6ouIfb8bL26z34IbzQYB3I/wQycrI+YMLFiQ==; 5:h2C7dd5FFJs3AUKtrTfdUDkeBDT+ZxHqH8ArW9qt49eZa2gcprhV8MKaP3c2TF1WDQtZgcOKsaDXbvAZa3kv3b4S2WuNRy2VvzDbrAUHAwfLNXAiHhNqTXUlWkhehXqWfh9Nz7ndE+HeXLxyowz55tlMlAorrDz8dL0OUOKeG6k=; 24:8hs69L5tXqEWVGLEg8vGko/vfqto51T2b8oIttWG+dsIP6urx+BqWePFK+xy/BG3d0LJaHSXLOPXeCM5eGmVWlaSRIwi7/tGf3PUdOOLNx8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB4PR04MB0765; 7:Qv02ghQkXLXCNFJVp0KgSQ2J9olkOtD2jw4HCbgzzOgRw1O09K8pDdO5xDtwCBwufC4UI7UJxp+UJNl6I5aCRVhcG0QY+kNFW9tVGMb565aXftnniCp55EOvq83SZUHhgSrFIP0z/xN71dHiTf/tXwp89oB21Ps1Ibe5we3Bn3lRgjSKjgMzqHS5z0WS+IYM4qSot+gIfFfpHm1b/Xh1ZlO7g+29iywCPVvcXvig1RVQJwgwSghxdpGJ31jYcY6c X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2018 09:45:38.3098 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa1faa38-3dda-48ec-2ac5-08d5e192e65d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR04MB0765 Subject: [dpdk-dev] [PATCH v2 12/16] bus/fslmc: cleanup unnecessary global variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Changes originally in the patch "drivers: cleanup unnecessary global variables" by Pavan. Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 3 +-- drivers/bus/fslmc/qbman/qbman_portal.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 713ec96..0714500 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -122,8 +122,7 @@ struct qbman_swp *qbman_swp_init(const struct qbman_swp_desc *d) p->vdq.valid_bit = QB_VALID_BIT; p->dqrr.next_idx = 0; p->dqrr.valid_bit = QB_VALID_BIT; - qman_version = p->desc.qman_version; - if ((qman_version & 0xFFFF0000) < QMAN_REV_4100) { + if ((p->desc.qman_version & 0xFFFF0000) < QMAN_REV_4100) { p->dqrr.dqrr_size = 4; p->dqrr.reset_bug = 1; } else { diff --git a/drivers/bus/fslmc/qbman/qbman_portal.h b/drivers/bus/fslmc/qbman/qbman_portal.h index 8bff0b4..dbea22a 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.h +++ b/drivers/bus/fslmc/qbman/qbman_portal.h @@ -7,7 +7,6 @@ #include "qbman_sys.h" #include -uint32_t qman_version; #define QMAN_REV_4000 0x04000000 #define QMAN_REV_4100 0x04010000 #define QMAN_REV_4101 0x04010001