diff mbox series

[dpdk-dev,2/2] eal/thread: fix return codes for rte_ctrl_thread_create()

Message ID 1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [dpdk-dev,1/2] eal/thread: fix return codes for rte_thread_setname() |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Stojaczyk, DariuszX June 8, 2018, 12:37 p.m. UTC 
  This function returned positive error numbers instead
of negative ones as desbribed in the doc. What's worse,
multiple of its callers only check for (rc < 0) to detect
failure.

It was incorrectly assumed that pthread_create
and pthread_setaffinity_np return negative errnos. They
always returns positive ones, so this patch negates their
return values before returning.

Fixes: 9e5afc72c909 ("eal: add function to create control threads")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
---
 lib/librte_eal/common/eal_common_thread.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Burakov, Anatoly June 18, 2018, 10:01 a.m. UTC | #1 
On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote:
> This function returned positive error numbers instead
> of negative ones as desbribed in the doc. What's worse,
> multiple of its callers only check for (rc < 0) to detect
> failure.
> 
> It was incorrectly assumed that pthread_create
> and pthread_setaffinity_np return negative errnos. They
> always returns positive ones, so this patch negates their
> return values before returning.
> 
> Fixes: 9e5afc72c909 ("eal: add function to create control threads")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Olivier Matz June 25, 2018, 2:40 p.m. UTC | #2 
On Mon, Jun 18, 2018 at 11:01:40AM +0100, Burakov, Anatoly wrote:
> On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote:
> > This function returned positive error numbers instead
> > of negative ones as desbribed in the doc. What's worse,
> > multiple of its callers only check for (rc < 0) to detect
> > failure.
> > 
> > It was incorrectly assumed that pthread_create
> > and pthread_setaffinity_np return negative errnos. They
> > always returns positive ones, so this patch negates their
> > return values before returning.
> > 
> > Fixes: 9e5afc72c909 ("eal: add function to create control threads")
> > Cc: olivier.matz@6wind.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> > ---
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Thanks for the fix.
diff mbox series

Patch

diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 8110ac2..48ef4d6 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -175,7 +175,7 @@  rte_ctrl_thread_create(pthread_t *thread, const char *name,
 
 	params = malloc(sizeof(*params));
 	if (!params)
-		return -1;
+		return -ENOMEM;
 
 	params->start_routine = start_routine;
 	params->arg = arg;
@@ -185,7 +185,7 @@  rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
 	if (ret != 0) {
 		free(params);
-		return ret;
+		return -ret;
 	}
 
 	if (name != NULL) {
@@ -228,5 +228,5 @@  rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	}
 	pthread_cancel(*thread);
 	pthread_join(*thread, NULL);
-	return ret;
+	return -ret;
 }