diff mbox series

[dpdk-dev] net/nfp: fix unused header reference

Message ID 1528454414-9996-1-git-send-email-alejandro.lucero@netronome.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [dpdk-dev] net/nfp: fix unused header reference |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Alejandro Lucero June 8, 2018, 10:40 a.m. UTC 
  Apart from not being used, this is causing problem when compiling
DPDK with the musl library as reported by bugzilla.

Fixes: c7e9729da6b5 ("net/nfp: support CPP")

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Ferruh Yigit June 8, 2018, 7:49 p.m. UTC | #1 
On 6/8/2018 11:40 AM, Alejandro Lucero wrote:
> Apart from not being used, this is causing problem when compiling
> DPDK with the musl library as reported by bugzilla.

If this is fixing a bugzilla issue, can you please use defined syntax to
document it:

Bugzilla ID: ###
Fixes: ############ ("....")
Cc: stable@dpdk.org --> [optional if needs to go in stable tree]

> 
> Fixes: c7e9729da6b5 ("net/nfp: support CPP")
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
>  drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> index b8541c5..d46574b 100644
> --- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> @@ -13,7 +13,6 @@
>  #include <stdlib.h>
>  #include <ctype.h>
>  #include <inttypes.h>
> -#include <sys/cdefs.h>
>  #include <sys/stat.h>
>  #include <limits.h>
>  #include <errno.h>
>
Alejandro Lucero June 11, 2018, 8:35 a.m. UTC | #2 
Sure. I will send another version adding that syntax.

Thanks

On Fri, Jun 8, 2018 at 8:49 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 6/8/2018 11:40 AM, Alejandro Lucero wrote:
> > Apart from not being used, this is causing problem when compiling
> > DPDK with the musl library as reported by bugzilla.
>
> If this is fixing a bugzilla issue, can you please use defined syntax to
> document it:
>
> Bugzilla ID: ###
> Fixes: ############ ("....")
> Cc: stable@dpdk.org --> [optional if needs to go in stable tree]
>
> >
> > Fixes: c7e9729da6b5 ("net/nfp: support CPP")
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> >  drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > index b8541c5..d46574b 100644
> > --- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > @@ -13,7 +13,6 @@
> >  #include <stdlib.h>
> >  #include <ctype.h>
> >  #include <inttypes.h>
> > -#include <sys/cdefs.h>
> >  #include <sys/stat.h>
> >  #include <limits.h>
> >  #include <errno.h>
> >
>
>
diff mbox series

Patch

diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
index b8541c5..d46574b 100644
--- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
+++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
@@ -13,7 +13,6 @@ 
 #include <stdlib.h>
 #include <ctype.h>
 #include <inttypes.h>
-#include <sys/cdefs.h>
 #include <sys/stat.h>
 #include <limits.h>
 #include <errno.h>