From patchwork Mon May 28 09:03:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Green X-Patchwork-Id: 40460 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3EE12C57; Mon, 28 May 2018 11:03:48 +0200 (CEST) Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 48ED52C57 for ; Mon, 28 May 2018 11:03:47 +0200 (CEST) From: Andy Green To: dev@dpdk.org Date: Mon, 28 May 2018 17:03:43 +0800 Message-ID: <152749822351.44120.16656625173859188832.stgit@localhost.localdomain> In-Reply-To: <152749815575.44120.3090426090234773551.stgit@localhost.localdomain> References: <152749815575.44120.3090426090234773551.stgit@localhost.localdomain> User-Agent: StGit/unknown-version Subject: [dpdk-dev] [PATCH v2 2/2] ring: fix sign conversion warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On gcc 5.4.0 / native aarch64 from Ubuntu 16.04: /home/agreen/lagopus/src/dpdk/build/include/rte_ring.h: In function '__rte_ring_do_dequeue': /home/agreen/lagopus/src/dpdk/build/include/rte_ring.h: 385:35: warning: conversion to 'int' from 'unsigned int' may change the sign of the result [-Wsign-conversion] n = __rte_ring_move_cons_head(r, is_sc, n, behavior, ^ Signed-off-by: Andy Green Fixes: e8ed5056c8 ("ring: remove signed type flip-flopping") ^ Acked-by: Olivier Matz --- lib/librte_ring/rte_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index 124582251..de1a5f366 100644 --- a/lib/librte_ring/rte_ring.h +++ b/lib/librte_ring/rte_ring.h @@ -382,7 +382,7 @@ __rte_ring_do_dequeue(struct rte_ring *r, void **obj_table, uint32_t cons_head, cons_next; uint32_t entries; - n = __rte_ring_move_cons_head(r, is_sc, n, behavior, + n = __rte_ring_move_cons_head(r, (int)is_sc, n, behavior, &cons_head, &cons_next, &entries); if (n == 0) goto end;