[dpdk-dev] net/cxgbe: report configured link auto-negotiation
Checks
Commit Message
Report current configured link auto-negotiation. Also initialize
rte_eth_link.
Coverity issue: 280648
Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link down")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
drivers/net/cxgbe/cxgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 5/23/2018 7:00 PM, Rahul Lakkireddy wrote:
> Report current configured link auto-negotiation. Also initialize
> rte_eth_link.
>
> Coverity issue: 280648
> Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link down")
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Will postpone to next release, thanks!
On 5/23/2018 7:00 PM, Rahul Lakkireddy wrote:
> Report current configured link auto-negotiation. Also initialize
> rte_eth_link.
>
> Coverity issue: 280648
> Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link down")
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied to dpdk-next-net/master, thanks.
@@ -204,13 +204,14 @@ int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,
struct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);
struct adapter *adapter = pi->adapter;
struct sge *s = &adapter->sge;
- struct rte_eth_link new_link;
+ struct rte_eth_link new_link = { 0 };
unsigned int work_done, budget = 4;
cxgbe_poll(&s->fw_evtq, NULL, budget, &work_done);
new_link.link_status = force_linkup(adapter) ?
ETH_LINK_UP : pi->link_cfg.link_ok;
+ new_link.link_autoneg = pi->link_cfg.autoneg;
new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
new_link.link_speed = pi->link_cfg.speed;